Skip to content

Commit 2a3b2d5

Browse files
committed
Simple integration test
1 parent f486088 commit 2a3b2d5

File tree

2 files changed

+40
-4
lines changed

2 files changed

+40
-4
lines changed

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/FirestoreTest.java

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,4 +1241,39 @@ public void testPendingWriteTaskResolveWhenOfflineIfThereIsNoPending() {
12411241

12421242
assertTrue(awaitsPendingWrites.isComplete() && awaitsPendingWrites.isSuccessful());
12431243
}
1244+
1245+
@Test
1246+
public void testGetDocumentWithMemoryLruGCEnabled() {
1247+
FirebaseFirestore db = testFirestore();
1248+
db.setFirestoreSettings(
1249+
new FirebaseFirestoreSettings.Builder(db.getFirestoreSettings())
1250+
.setPersistenceEnabled(false)
1251+
.setMemoryLruGcEnabled(true)
1252+
.build());
1253+
1254+
DocumentReference doc = db.collection("abc").document("123");
1255+
waitFor(doc.set(map("key", "value")));
1256+
1257+
DocumentSnapshot snapshot = waitFor(doc.get(Source.CACHE));
1258+
assertTrue(snapshot.exists());
1259+
assertTrue(snapshot.getMetadata().isFromCache());
1260+
assertEquals(snapshot.getData(), map("key", "value"));
1261+
}
1262+
1263+
@Test
1264+
public void testGetDocumentWithMemoryEagerGcEnabled() {
1265+
FirebaseFirestore db = testFirestore();
1266+
db.setFirestoreSettings(
1267+
new FirebaseFirestoreSettings.Builder(db.getFirestoreSettings())
1268+
.setPersistenceEnabled(false)
1269+
.setMemoryLruGcEnabled(false)
1270+
.build());
1271+
1272+
DocumentReference doc = db.collection("abc").document("123");
1273+
waitFor(doc.set(map("key", "value")));
1274+
1275+
Exception e = waitForException(doc.get(Source.CACHE));
1276+
assertTrue(e instanceof FirebaseFirestoreException);
1277+
assertEquals(((FirebaseFirestoreException) e).getCode(), Code.UNAVAILABLE);
1278+
}
12441279
}

firebase-firestore/src/main/java/com/google/firebase/firestore/core/MemoryComponentProvider.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,13 @@ protected AndroidConnectivityMonitor createConnectivityMonitor(Configuration con
6767

6868
@Override
6969
protected Persistence createPersistence(Configuration configuration) {
70-
if(configuration.getSettings().isMemoryLruGcEnabled()) {
70+
if (configuration.getSettings().isMemoryLruGcEnabled()) {
7171
LocalSerializer serializer =
72-
new LocalSerializer(new RemoteSerializer(configuration.getDatabaseInfo().getDatabaseId()));
72+
new LocalSerializer(
73+
new RemoteSerializer(configuration.getDatabaseInfo().getDatabaseId()));
7374
LruGarbageCollector.Params params =
74-
LruGarbageCollector.Params.WithCacheSizeBytes(
75-
configuration.getSettings().getCacheSizeBytes());
75+
LruGarbageCollector.Params.WithCacheSizeBytes(
76+
configuration.getSettings().getCacheSizeBytes());
7677
return MemoryPersistence.createLruGcMemoryPersistence(params, serializer);
7778
}
7879

0 commit comments

Comments
 (0)