Skip to content

Commit 4b9b030

Browse files
committed
Add more comments for development mode
1 parent e1c3de7 commit 4b9b030

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FeedbackActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public class FeedbackActivity extends AppCompatActivity {
4646
"com.google.firebase.appdistribution.FeedbackActivity.SCREENSHOT_URI";
4747

4848
private FeedbackSender feedbackSender;
49-
private String releaseName;
49+
@Nullable private String releaseName; // in development-mode the releaseName might be null
5050
private CharSequence infoText;
5151
@Nullable private Uri screenshotUri;
5252

@@ -113,6 +113,7 @@ private Bitmap readScreenshot() {
113113

114114
public void submitFeedback(View view) {
115115
if (releaseName == null) {
116+
// Don't actually send feedback in development-mode
116117
Toast.makeText(this, R.string.feedback_no_release, Toast.LENGTH_LONG).show();
117118
finish();
118119
return;

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,7 @@ private void doStartFeedback(CharSequence infoText, @Nullable Uri screenshotUri)
397397
.onSuccessTask(
398398
taskExecutor,
399399
releaseName ->
400+
// in development-mode the releaseName might be null
400401
launchFeedbackActivity(releaseName, infoText, screenshotUri)
401402
.addOnFailureListener(
402403
e -> {
@@ -417,6 +418,7 @@ private Task<Void> launchFeedbackActivity(
417418
activity -> {
418419
LogWrapper.getInstance().i("Launching feedback activity");
419420
Intent intent = new Intent(activity, FeedbackActivity.class);
421+
// in development-mode the releaseName might be null
420422
intent.putExtra(FeedbackActivity.RELEASE_NAME_EXTRA_KEY, releaseName);
421423
intent.putExtra(FeedbackActivity.INFO_TEXT_EXTRA_KEY, infoText);
422424
if (screenshotUri != null) {

0 commit comments

Comments
 (0)