Skip to content

Commit 538d656

Browse files
committed
Resolve some changes from the rebase on fad/next
1 parent 25a9d6c commit 538d656

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ buildscript {
3939
classpath 'net.ltgt.gradle:gradle-errorprone-plugin:1.3.0'
4040
classpath 'gradle.plugin.com.github.sherter.google-java-format:google-java-format-gradle-plugin:0.9'
4141
classpath 'com.google.gms:google-services:4.3.3'
42+
classpath "com.ncorti.ktfmt.gradle:plugin:0.11.0"
4243
classpath 'org.jlleitschuh.gradle:ktlint-gradle:9.2.1'
4344
classpath 'com.google.firebase:firebase-appdistribution-gradle:3.0.2'
4445
}

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/LogWrapper.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,6 @@ void e(@NonNull String msg, @NonNull Throwable tr) {
8484
Log.e(LOG_TAG, msg, tr);
8585
}
8686

87-
void e(@NonNull String additionalTag, @NonNull String msg) {
88-
Log.e(LOG_TAG, prependTag(additionalTag, msg));
89-
}
90-
9187
void e(@NonNull String additionalTag, @NonNull String msg, @NonNull Throwable tr) {
9288
Log.e(LOG_TAG, prependTag(additionalTag, msg), tr);
9389
}

firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/impl/ImageUtilsTest.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,15 @@ public void readScaledImage_negativeDimensions_throws() {
163163
}
164164

165165
@Test
166-
public void readScaledImage_doesntExist_returnsNull() throws IOException {
167-
Bitmap result =
168-
ImageUtils.readScaledImage(
169-
contentResolver,
170-
Uri.fromFile(new File("nonexistent.png")),
171-
TEST_SCREENSHOT_WIDTH / 4,
172-
TEST_SCREENSHOT_HEIGHT / 4);
173-
assertThat(result).isNull();
166+
public void readScaledImage_doesntExist_throws() throws IOException {
167+
assertThrows(
168+
IOException.class,
169+
() ->
170+
ImageUtils.readScaledImage(
171+
contentResolver,
172+
Uri.fromFile(new File("nonexistent.png")),
173+
TEST_SCREENSHOT_WIDTH / 4,
174+
TEST_SCREENSHOT_HEIGHT / 4));
174175
}
175176

176177
private static byte[] writeBitmapToByteArray() throws IOException {

firebase-appdistribution/test-app/src/main/java/com/googletest/firebase/appdistribution/testapp/MainActivity.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import java.util.concurrent.Executors
2929
class MainActivity : AppCompatActivity() {
3030

3131
var firebaseAppDistribution = Firebase.appDistribution
32+
var updateTask: Task<Void>? = null
3233
val executorService: ExecutorService = Executors.newFixedThreadPool(1)
3334

3435
lateinit var signInButton: AppCompatButton
@@ -47,8 +48,6 @@ class MainActivity : AppCompatActivity() {
4748
lateinit var progressBar: ProgressBar
4849
lateinit var feedbackTriggerMenu: TextInputLayout
4950

50-
var updateTask: Task<Void>? = null
51-
5251
override fun onCreate(savedInstanceState: Bundle?) {
5352
super.onCreate(savedInstanceState)
5453
setContentView(R.layout.activity_main)

0 commit comments

Comments
 (0)