Skip to content

Commit 59df96e

Browse files
authored
Suppress continuation warnings in UpdateTaskImpl (#4536)
1 parent ae0932d commit 59df96e

File tree

1 file changed

+8
-1
lines changed
  • firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl

1 file changed

+8
-1
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/UpdateTaskImpl.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
package com.google.firebase.appdistribution.impl;
1616

17+
import android.annotation.SuppressLint;
1718
import android.app.Activity;
1819
import androidx.annotation.GuardedBy;
1920
import androidx.annotation.NonNull;
@@ -37,7 +38,6 @@
3738
import java.util.concurrent.Executor;
3839

3940
/** Implementation of UpdateTask, the return type of updateApp. */
40-
// TODO(b/261013814): Use an explicit executor in continuations.
4141
class UpdateTaskImpl extends UpdateTask {
4242

4343
@Nullable
@@ -141,6 +141,7 @@ public Exception getException() {
141141
return getTask().getException();
142142
}
143143

144+
@SuppressLint("TaskMainThread") // Uses default (main thread) executor to match caller's intent
144145
@NonNull
145146
@Override
146147
public Task<Void> addOnSuccessListener(
@@ -162,6 +163,7 @@ public Task<Void> addOnSuccessListener(
162163
return getTask().addOnSuccessListener(activity, onSuccessListener);
163164
}
164165

166+
@SuppressLint("TaskMainThread") // Uses default (main thread) executor to match caller's intent
165167
@NonNull
166168
@Override
167169
public Task<Void> addOnFailureListener(@NonNull OnFailureListener onFailureListener) {
@@ -182,6 +184,7 @@ public Task<Void> addOnFailureListener(
182184
return getTask().addOnFailureListener(activity, onFailureListener);
183185
}
184186

187+
@SuppressLint("TaskMainThread") // Uses default (main thread) executor to match caller's intent
185188
@NonNull
186189
@Override
187190
public Task<Void> addOnCompleteListener(@NonNull OnCompleteListener<Void> onCompleteListener) {
@@ -202,6 +205,7 @@ public Task<Void> addOnCompleteListener(
202205
return getTask().addOnCompleteListener(activity, onCompleteListener);
203206
}
204207

208+
@SuppressLint("TaskMainThread") // Uses default (main thread) executor to match caller's intent
205209
@NonNull
206210
@Override
207211
public Task<Void> addOnCanceledListener(@NonNull OnCanceledListener onCanceledListener) {
@@ -222,6 +226,7 @@ public Task<Void> addOnCanceledListener(
222226
return getTask().addOnCanceledListener(activity, onCanceledListener);
223227
}
224228

229+
@SuppressLint("TaskMainThread") // Uses default (main thread) executor to match caller's intent
225230
@NonNull
226231
@Override
227232
public <TContinuationResult> Task<TContinuationResult> continueWith(
@@ -236,6 +241,7 @@ public <TContinuationResult> Task<TContinuationResult> continueWith(
236241
return getTask().continueWith(executor, continuation);
237242
}
238243

244+
@SuppressLint("TaskMainThread") // Uses default (main thread) executor to match caller's intent
239245
@NonNull
240246
@Override
241247
public <TContinuationResult> Task<TContinuationResult> continueWithTask(
@@ -251,6 +257,7 @@ public <TContinuationResult> Task<TContinuationResult> continueWithTask(
251257
return getTask().continueWithTask(executor, continuation);
252258
}
253259

260+
@SuppressLint("TaskMainThread") // Uses default (main thread) executor to match caller's intent
254261
@NonNull
255262
@Override
256263
public <TContinuationResult> Task<TContinuationResult> onSuccessTask(

0 commit comments

Comments
 (0)