Skip to content

Suppress continuation warnings in UpdateTaskImpl #4536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Suppress continuation warnings in UpdateTaskImpl #4536

merged 1 commit into from
Jan 9, 2023

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Jan 6, 2023 •
edited
Loading

UpdateTask extends Task, so it makes sense to use the default (main thread) executor when none is specified.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (f40c24a) to 76.63% (23b246d) by ?.

    44 individual files with coverage change

    FilenameBase (f40c24a)Merge (23b246d)Diff
    AabUpdater.java?98.41%?
    ApkInstaller.java?100.00%?
    ApkUpdater.java?93.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?84.62%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.12%?
    FeedbackSender.java?84.62%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionLifecycleNotifier.java?91.60%?
    FirebaseAppDistributionNotificationsManager.java?87.18%?
    FirebaseAppDistributionRegistrar.java?87.04%?
    FirebaseAppDistributionTesterApiClient.java?88.54%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?100.00%?
    NewReleaseFetcher.java?85.71%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?87.95%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?41.18%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.18%?
    TesterSignInManager.java?95.18%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KGaGMpvdZc.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Unit Test Results

172 tests   172 ✔️  41s ⏱️
  17 suites      0 💤
  17 files        0 ❌

Results for commit bae7fb9.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (f40c24a)Merge (23b246d)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-annotations

    TypeBase (f40c24a)Merge (23b246d)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)

  • firebase-appdistribution

    TypeBase (f40c24a)Merge (23b246d)Diff
    aar?195 kB? (?)
    apk (aggressive)?889 kB? (?)
    apk (release)?2.62 MB? (?)

  • firebase-appdistribution-api

    TypeBase (f40c24a)Merge (23b246d)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?112 kB? (?)
    apk (release)?1.27 MB? (?)

  • firebase-common

    TypeBase (f40c24a)Merge (23b246d)Diff
    aar?67.4 kB? (?)
    apk (aggressive)?111 kB? (?)
    apk (release)?1.26 MB? (?)

  • firebase-components

    TypeBase (f40c24a)Merge (23b246d)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?23.1 kB? (?)
    apk (release)?596 kB? (?)

  • firebase-installations

    TypeBase (f40c24a)Merge (23b246d)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?116 kB? (?)
    apk (release)?1.28 MB? (?)

  • firebase-installations-interop

    TypeBase (f40c24a)Merge (23b246d)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/agHYY0eowT.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (23b246d) and the base commit (f40c24a) are not available.

No macrobenchmark data found for the base commit (f40c24a). Analysis for the CI merge commit (23b246d) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MBlKENAGBF/index.html

@lfkellogg lfkellogg merged commit 59df96e into fad/in-app-feedback Jan 9, 2023
@lfkellogg lfkellogg deleted the lk/updatetask-continuations branch January 9, 2023 16:26
@vkryachko
Copy link
Member

I am surprised this is needed after #4394, can you please double check?

kaibolay pushed a commit that referenced this pull request Jan 23, 2023
@lfkellogg @kaibolay
Suppress continuation warnings in UpdateTaskImpl (#4536)
e075e7f
@lfkellogg
Copy link
Contributor Author

I am surprised this is needed after #4394, can you please double check?

Ah, didn't notice that, thanks. Follow-up here: #4589

lfkellogg added a commit that referenced this pull request Jan 25, 2023
@lfkellogg
Suppress continuation warnings in UpdateTaskImpl (#4536)
e9f9360
lfkellogg added a commit that referenced this pull request Jan 25, 2023
@lfkellogg
Suppress continuation warnings in UpdateTaskImpl (#4536)
74858a6
@firebase firebase locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfkellogg @google-oss-bot @vkryachko @kaibolay