Remove unused parameter from LocalStore tests (#721)

Author: schmidt-sebastian

firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalStoreTestCase.java

@@ -824,10 +824,13 @@ public void testThrowsAwayDocumentsWithUnknownTargetIDsImmediately() {
       return;
     }
 
-    int targetID = 321;
+    int unknownTargetID = 321;
     applyRemoteEvent(
-        updateRemoteEvent(doc("foo/bar", 1, map()), emptyList(), emptyList(), asList(targetID)));
-
+        updateRemoteEvent(
+            doc("foo/bar", 1, map()),
+            /* updatedInTargets= */ asList(unknownTargetID),
+            /* removedFromTargets= */ emptyList(),
+            /* activeTargets= */ emptyList()));
     assertNotContains("foo/bar");
   }
 

firebase-firestore/src/testUtil/java/com/google/firebase/firestore/testutil/TestUtil.java

@@ -416,14 +416,17 @@ public QueryData getQueryDataForTarget(int targetId) {
 
   public static RemoteEvent updateRemoteEvent(
       MaybeDocument doc, List<Integer> updatedInTargets, List<Integer> removedFromTargets) {
-    return updateRemoteEvent(doc, updatedInTargets, removedFromTargets, Collections.emptyList());
+    List<Integer> activeTargets = new ArrayList<>();
+    activeTargets.addAll(updatedInTargets);
+    activeTargets.addAll(removedFromTargets);
+    return updateRemoteEvent(doc, updatedInTargets, removedFromTargets, activeTargets);
   }
 
   public static RemoteEvent updateRemoteEvent(
       MaybeDocument doc,
       List<Integer> updatedInTargets,
       List<Integer> removedFromTargets,
-      List<Integer> limboTargets) {
+      List<Integer> activeTargets) {
     DocumentChange change =
         new DocumentChange(updatedInTargets, removedFromTargets, doc.getKey(), doc);
     WatchChangeAggregator aggregator =
@@ -436,11 +439,9 @@ public ImmutableSortedSet<DocumentKey> getRemoteKeysForTarget(int targetId) {
 
               @Override
               public QueryData getQueryDataForTarget(int targetId) {
-                boolean isLimbo =
-                    !(updatedInTargets.contains(targetId) || removedFromTargets.contains(targetId));
-                QueryPurpose purpose =
-                    isLimbo ? QueryPurpose.LIMBO_RESOLUTION : QueryPurpose.LISTEN;
-                return queryData(targetId, purpose, doc.getKey().toString());
+                return activeTargets.contains(targetId)
+                    ? queryData(targetId, QueryPurpose.LISTEN, doc.getKey().toString())
+                    : null;
               }
             });
     aggregator.handleDocumentChange(change);