Skip to content

Remove unused parameter from LocalStore tests #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

Remove unused parameter from LocalStore tests #721

merged 1 commit into from
Aug 21, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

This PR removes the unused limboTargets param and updates the test testThrowsAwayDocumentsWithUnknownTargetIDsImmediately to actually return null from getQueryDataForTarget for the inactive target.

@googlebot googlebot added the cla: yes Override cla label Aug 20, 2019
@ashwinraghav
Copy link
Contributor

/retest

thebrianchen
thebrianchen approved these changes Aug 21, 2019
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit 5e35f4a into master Aug 21, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/removeunused branch August 21, 2019 18:20
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schmidt-sebastian @ashwinraghav @thebrianchen @googlebot @google-oss-bot