Fix workflows for Firebase Sessions (#4841)

* Use googleServices.gradle

* Move package level function to object to fix api surface check

* Add android manifest file with versionName set to fix android tests

* Update pinned deps

* Make getApplicationInfo look leaner

Author: mrober

firebase-sessions/firebase-sessions.gradle.kts

@@ -42,11 +42,11 @@ android {
 }
 
 dependencies {
+  implementation("com.google.firebase:firebase-common-ktx:20.3.2")
+  implementation("com.google.firebase:firebase-components:17.1.0")
+  implementation("com.google.firebase:firebase-encoders-json:18.0.1")
   implementation("com.google.firebase:firebase-encoders:17.0.0")
-  implementation(project(":encoders:firebase-encoders-json"))
   implementation("com.google.firebase:firebase-installations-interop:17.1.0")
-  implementation("com.google.firebase:firebase-common-ktx:20.3.1")
-  implementation("com.google.firebase:firebase-components:17.1.0")
   implementation(libs.androidx.annotation)
 
   runtimeOnly("com.google.firebase:firebase-installations:17.1.3")

firebase-sessions/src/androidTest/AndroidManifest.xml

@@ -0,0 +1,26 @@
+<!--
+  ~ Copyright 2023 Google LLC
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  package="com.google.firebase.sessions.test"
+  android:versionCode="1"
+  android:versionName="1.0.0">
+
+  <application>
+
+  </application>
+
+</manifest>

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/ApplicationInfo.kt

@@ -16,7 +16,6 @@
 
 package com.google.firebase.sessions
 
-import com.google.firebase.FirebaseApp
 import com.google.firebase.encoders.json.NumberedEnum
 
 /** Enum denoting different development environments. */
@@ -58,17 +57,3 @@ internal data class ApplicationInfo(
   /** The android application information for the app. */
   val androidAppInfo: AndroidApplicationInfo,
 )
-
-internal fun getApplicationInfo(firebaseApp: FirebaseApp): ApplicationInfo {
-  val packageName = firebaseApp.applicationContext.packageName
-  val packageInfo = firebaseApp.applicationContext.packageManager.getPackageInfo(packageName, 0)
-
-  return ApplicationInfo(
-    appId = firebaseApp.options.applicationId,
-    deviceModel = "",
-    sessionSdkVersion = BuildConfig.VERSION_NAME,
-    logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD,
-    androidAppInfo =
-      AndroidApplicationInfo(packageName = packageName, versionName = packageInfo.versionName)
-  )
-}

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionEvents.kt

@@ -74,4 +74,19 @@ internal object SessionEvents {
         ),
       applicationInfo = getApplicationInfo(firebaseApp)
     )
+
+  fun getApplicationInfo(firebaseApp: FirebaseApp): ApplicationInfo {
+    val context = firebaseApp.applicationContext
+    val packageName = context.packageName
+    val packageInfo = context.packageManager.getPackageInfo(packageName, 0)
+
+    return ApplicationInfo(
+      appId = firebaseApp.options.applicationId,
+      deviceModel = "",
+      sessionSdkVersion = BuildConfig.VERSION_NAME,
+      logEnvironment = LogEnvironment.LOG_ENVIRONMENT_PROD,
+      androidAppInfo =
+        AndroidApplicationInfo(packageName = packageName, versionName = packageInfo.versionName)
+    )
+  }
 }

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/ApplicationInfoTest.kt

@@ -31,7 +31,7 @@ class ApplicationInfoTest {
 
   @Test
   fun applicationInfo_populatesInfoCorrectly() {
-    val applicationInfo = getApplicationInfo(FakeFirebaseApp.fakeFirebaseApp())
+    val applicationInfo = SessionEvents.getApplicationInfo(FakeFirebaseApp.fakeFirebaseApp())
     assertThat(applicationInfo)
       .isEqualTo(
         ApplicationInfo(

firebase-sessions/test-app/test-app.gradle.kts

@@ -17,7 +17,6 @@
 plugins {
   id("com.android.application")
   id("org.jetbrains.kotlin.android")
-  id("com.google.gms.google-services")
 }
 
 android {
@@ -47,3 +46,6 @@ dependencies {
   implementation("androidx.core:core-ktx:1.9.0")
   implementation("com.google.android.material:material:1.8.0")
 }
+
+extra["packageName"] = "com.google.firebase.testing.sessions"
+apply(from = "../../gradle/googleServices.gradle")