Fix workflows for Firebase Sessions #4841
Conversation
Coverage Report 1Affected Products
Test Logs |
|
The public api surface has changed for the subproject firebase-sessions: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The Javadoc failure should be fixed when #4847 lands. |
| implementation("com.google.firebase:firebase-common-ktx:20.3.2") | ||
| implementation("com.google.firebase:firebase-components:17.1.0") | ||
| implementation("com.google.firebase:firebase-encoders-json:18.0.1") |
There was a problem hiding this comment.
Changes look good to me here. But curious why we choose pinned versions over a HEAD dependency! Would be a good learning for all of for future.
There was a problem hiding this comment.
There was an effort across the whole repo to pin dep versions see go/firebase-android-cross-deps
|
|
||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| package="com.google.firebase.sessions.test" | ||
| android:versionCode="1" |
There was a problem hiding this comment.
Can we do a dynamic version code here? For eg: number of days since January 2023? I'm trying to see if we can get some dynamicity in the data that is generated especially for the ApplicationInfo proto message.
There was a problem hiding this comment.
I don't see an easy way to do that inside this manifest file. Maybe we can do it programmatically for that one test later.
|
|
||
| fun getApplicationInfo(firebaseApp: FirebaseApp): ApplicationInfo { | ||
| val packageName = firebaseApp.applicationContext.packageName | ||
| val packageInfo = firebaseApp.applicationContext.packageManager.getPackageInfo(packageName, 0) |
There was a problem hiding this comment.
To avoid such a long include, can we import the package to make it look leaner?
There was a problem hiding this comment.
These aren't package imports, these are getters. Like firebaseApp.getApplicationContext().getPackageManager(). I can still make it look leaner by adding another val.
| @@ -47,3 +46,6 @@ dependencies { | |||
| implementation("androidx.core:core-ktx:1.9.0") | |||
| implementation("com.google.android.material:material:1.8.0") | |||
| } | |||
|
|
|||
| extra["packageName"] = "com.google.firebase.testing.sessions" | |||
There was a problem hiding this comment.
Interesting. Why specify the package name here and not in the manifest?
There was a problem hiding this comment.
This is how we pass a package name to the googleServices.gradle file below.
Fix workflows for Firebase Sessions
googleServices.gradlefile instead of the Google Services plugin directlyApplicationInfoKtthat was showing up in the api surfaceAndroidManifest.xmlfile withversionNameset to fix android tests