Skip to content

Include Kotlin directories in the Dackka plugin #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

Include Kotlin directories in the Dackka plugin #4847

merged 1 commit into from
Apr 4, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 4, 2023

Include Kotlin directories in the Dackka plugin.

The generateDackkaDocumentation task was not outputting anything on firebase-sessions because it was ignoring the main/kotlin/ src dir, it only looked at main/java/ before. This was causing some workflows to fail on every PR since sessions is entirely written in Kotlin.

@mrober mrober requested a review from davidmotson April 4, 2023 13:29
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

buildSrc Test Results

28 tests   28 ✔️  1m 20s ⏱️
  5 suites    0 💤
  5 files      0 ❌

Results for commit 209c1e3.

@mrober mrober mentioned this pull request Apr 4, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Unit Test Results

   774 files  +   616     774 suites  +616   32m 35s ⏱️ + 30m 20s
4 853 tests +3 736  4 830 ✔️ +3 729  21 💤 +  5  2 ❌ +2 
9 503 runs  +7 269  9 459 ✔️ +7 257  42 💤 +10  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 209c1e3. ± Comparison against base commit 26de539.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (26de539) and merge commit (755c1f0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FlbYUsN0Cm.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.13% (26de539) to 50.22% (755c1f0) by +0.09%.

    FilenameBase (26de539)Merge (755c1f0)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    WebsocketConnection.java32.77%35.03%+2.26%

  • firebase-messaging

    Overall coverage changed from ? (26de539) to 85.29% (755c1f0) by ?.

    41 individual files with coverage change

    FilenameBase (26de539)Merge (755c1f0)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?77.09%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.78%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/16y2buNSN8.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (117,055 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8THs4YpsQy/index.html

@daymxn daymxn self-requested a review April 4, 2023 17:49
daymxn
daymxn approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We haven't had any kotlin directories yet, so this never came up. Our other kotlin files lived under the java directory :')

@davidmotson davidmotson merged commit 9a38058 into master Apr 4, 2023
@davidmotson davidmotson deleted the javadoc-kotlin branch April 4, 2023 19:35
@firebase firebase locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
api: sessions main-merge-ack no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrober @google-oss-bot @daymxn @samedson @davidmotson