Skip to content

Commit 7e49209

Browse files
authored
Prefer immutable set for test initialization (#4904)
* Change initialization of logSources in test * Use immutable sets
1 parent 8840eee commit 7e49209

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

firebase-common/src/test/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatControllerTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import android.content.SharedPreferences;
2929
import androidx.test.core.app.ApplicationProvider;
3030
import androidx.test.ext.junit.runners.AndroidJUnit4;
31+
import com.google.common.collect.ImmutableSet;
3132
import com.google.firebase.platforminfo.UserAgentPublisher;
3233
import java.io.ByteArrayOutputStream;
3334
import java.io.IOException;
@@ -53,12 +54,7 @@ public class DefaultHeartBeatControllerTest {
5354
private final HeartBeatInfoStorage storage = mock(HeartBeatInfoStorage.class);
5455
private final UserAgentPublisher publisher = mock(UserAgentPublisher.class);
5556
private final Context applicationContext = ApplicationProvider.getApplicationContext();
56-
private final Set<HeartBeatConsumer> logSources =
57-
new HashSet<HeartBeatConsumer>() {
58-
{
59-
add(new HeartBeatConsumer() {});
60-
}
61-
};
57+
private final Set<HeartBeatConsumer> logSources = ImmutableSet.of(new HeartBeatConsumer() {});
6258
private DefaultHeartBeatController heartBeatController;
6359

6460
@Before

0 commit comments

Comments
 (0)