Prefer immutable set for test initialization

[rlazo]

No description provided.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

[google-oss-bot]

Coverage Report ¹

Affected Products

No changes between base commit (8840eee) and merge commit (578faf2).

Test Logs

• Base (8840eee): https://github.com/firebase/firebase-android-sdk/actions/runs/4724011945
• Merge (578faf2): https://github.com/firebase/firebase-android-sdk/actions/runs/4725355065

1. https://storage.googleapis.com/firebase-sdk-metric-reports/p4uOCPRhrt.html

[github-actions]

Unit Test Results

  34 files   -    705    34 suites   - 705   1m 28s ⏱️ - 30m 20s
  57 tests  - 4 807    57 ✔️  - 4 783  0 💤  - 21  0 ❌  - 3 
114 runs   - 8 742  114 ✔️  - 8 698  0 💤  - 41  0 ❌  - 3 

Results for commit a105cee. ± Comparison against base commit 8840eee.

[daymxn]

This gives me an idea...

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (8840eee) and merge commit (578faf2).

Test Logs

• Base (8840eee): https://github.com/firebase/firebase-android-sdk/actions/runs/4724011945
• Merge (578faf2): https://github.com/firebase/firebase-android-sdk/actions/runs/4725355065

1. https://storage.googleapis.com/firebase-sdk-metric-reports/IWBIvvp8XR.html

[google-oss-bot]

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

• This report is for comparing the base commit (8840eee) and the CI merge commit (578faf2)
• Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
  • 8840eee: https://storage.googleapis.com/firebase-sdk-metric-reports/86WNrmyt1z/index.html
  • 578faf2: https://storage.googleapis.com/firebase-sdk-metric-reports/Qog39GvlRh/index.html

Startup Times

• ComponentDiscovery

  Device	Statistics	Distributions
  oriole-32	Percentile 8840eee 578faf2 Diff Significant (?) p10 460 ±53 μs 443 ±26 μs -16.6 μs (-3.6%) NO p25 504 ±62 μs 489 ±30 μs -15.0 μs (-3.0%) NO p50 606 ±66 μs 580 ±34 μs -26.7 μs (-4.4%) NO p75 726 ±88 μs 689 ±43 μs -36.6 μs (-5.0%) NO p90 893 ±103 μs 860 ±52 μs -32.7 μs (-3.7%) NO 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi
  redfin-30	Percentile 8840eee 578faf2 Diff Significant (?) p10 766 ±18 μs 761 ±14 μs -4.93 μs (-0.6%) NO p25 800 ±19 μs 800 ±18 μs -595 ns (-0.1%) NO p50 862 ±21 μs 881 ±45 μs +19.0 μs (+2.2%) NO p75 1.06 ±0.08 ms 1.13 ±0.1 ms +65.5 μs (+6.2%) NO p90 1.55 ±0.2 ms 1.60 ±0.3 ms +51.5 μs (+3.3%) NO 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi

• Firebase

  Device	Statistics	Distributions
  oriole-32	Percentile 8840eee 578faf2 Diff Significant (?) p10 3.96 ±0.5 ms 3.87 ±0.2 ms -96.6 μs (-2.4%) NO p25 4.31 ±0.8 ms 4.06 ±0.3 ms -248 μs (-5.8%) NO p50 4.69 ±1 ms 4.41 ±0.3 ms -285 μs (-6.1%) NO p75 5.22 ±1 ms 4.94 ±0.4 ms -275 μs (-5.3%) NO p90 5.93 ±1 ms 5.63 ±0.4 ms -300 μs (-5.1%) NO 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi
  redfin-30	Percentile 8840eee 578faf2 Diff Significant (?) p10 6.57 ±0.2 ms 6.53 ±0.1 ms -36.5 μs (-0.6%) NO p25 6.75 ±0.2 ms 6.72 ±0.1 ms -21.0 μs (-0.3%) NO p50 7.08 ±0.2 ms 7.11 ±0.2 ms +33.7 μs (+0.5%) NO p75 7.81 ±0.2 ms 7.81 ±0.2 ms -2.36 μs (-0.0%) NO p90 9.02 ±0.5 ms 9.11 ±0.6 ms +86.1 μs (+1.0%) NO 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi

• Runtime

  Device	Statistics	Distributions
  oriole-32	Percentile 8840eee 578faf2 Diff Significant (?) p10 3.39 ±0.4 ms 3.32 ±0.2 ms -61.2 μs (-1.8%) NO p25 3.69 ±0.7 ms 3.49 ±0.2 ms -202 μs (-5.5%) NO p50 4.00 ±0.9 ms 3.75 ±0.3 ms -246 μs (-6.2%) NO p75 4.46 ±0.9 ms 4.18 ±0.3 ms -280 μs (-6.3%) NO p90 5.10 ±1 ms 4.84 ±0.4 ms -260 μs (-5.1%) NO 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi
  redfin-30	Percentile 8840eee 578faf2 Diff Significant (?) p10 5.63 ±0.2 ms 5.61 ±0.1 ms -28.2 μs (-0.5%) NO p25 5.79 ±0.2 ms 5.77 ±0.1 ms -16.5 μs (-0.3%) NO p50 6.05 ±0.2 ms 6.03 ±0.1 ms -26.8 μs (-0.4%) NO p75 6.52 ±0.2 ms 6.47 ±0.2 ms -45.7 μs (-0.7%) NO p90 7.29 ±0.4 ms 7.27 ±0.3 ms -21.5 μs (-0.3%) NO 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi

• timeToInitialDisplay

  Device	Statistics	Distributions
  oriole-32	Percentile 8840eee 578faf2 Diff Significant (?) p10 198 ±17 ms 201 ±7 ms +3.18 ms (+1.6%) NO p25 208 ±23 ms 207 ±8 ms -265 μs (-0.1%) NO p50 220 ±33 ms 216 ±8 ms -4.27 ms (-1.9%) NO p75 230 ±38 ms 226 ±9 ms -4.21 ms (-1.8%) NO p90 240 ±41 ms 237 ±11 ms -2.49 ms (-1.0%) NO 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi
  redfin-30	Percentile 8840eee 578faf2 Diff Significant (?) p10 231 ±3 ms 252 ±4 ms +21.3 ms (+9.2%) YES p25 237 ±4 ms 258 ±4 ms +20.7 ms (+8.7%) YES p50 244 ±4 ms 265 ±5 ms +21.3 ms (+8.7%) MAYBE p75 253 ±6 ms 273 ±6 ms +20.3 ms (+8.0%) MAYBE p90 261 ±6 ms 282 ±6 ms +21.6 ms (+8.3%) MAYBE 20 test runs in comparison Commit Test Runs 8840eee 2023-04-17_17:40:38.170833_tmml 2023-04-17_17:40:38.175495_Gudd 2023-04-17_17:40:38.175516_vHCe 2023-04-17_17:40:38.175524_tLlG 2023-04-17_17:40:38.175534_YUxK 2023-04-17_17:40:38.175549_SNba 2023-04-17_17:40:38.175567_Meym 2023-04-17_17:40:38.175574_TlhS 2023-04-17_17:40:38.175580_LIVi 2023-04-17_17:40:38.175586_TtcW 578faf2 2023-04-17_20:29:05.629768_xObz 2023-04-17_20:29:05.635317_Lpyk 2023-04-17_20:29:05.635336_Cvgt 2023-04-17_20:29:05.635344_XWyG 2023-04-17_20:29:05.635351_zqBK 2023-04-17_20:29:05.635365_pltd 2023-04-17_20:29:05.635372_Dvmz 2023-04-17_20:29:05.635379_szzk 2023-04-17_20:29:05.635384_rydo 2023-04-17_20:29:05.635391_XBsi

1. https://storage.googleapis.com/firebase-sdk-metric-reports/BixnJRirs3/index.html