Skip to content

Commit 821c9f4

Browse files
committed
dataconnect.yml: don't bother killing the async processes because it's buggy and does not yield much (any?) benefit
1 parent df34a52 commit 821c9f4

File tree

1 file changed

+0
-67
lines changed

1 file changed

+0
-67
lines changed

.github/workflows/dataconnect.yml

Lines changed: 0 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -223,73 +223,6 @@ jobs:
223223
script: |
224224
set -eux && ./gradlew ${{ (inputs.gradleInfoLog && '--info') || '' }} :firebase-dataconnect:connectedCheck :firebase-dataconnect:connectors:connectedCheck
225225
226-
- name: Logcat Log Capture Stop
227-
if: steps.logcat-capture.outcome == 'success'
228-
continue-on-error: true
229-
run: |
230-
set -euo pipefail
231-
232-
echo "Sending SIGINT to logcat process $LOGCAT_PID"
233-
kill -s SIGINT "$LOGCAT_PID"
234-
235-
loop_count=0
236-
while kill -0 "$LOGCAT_PID" ; do
237-
loop_count=$((loop_count+1))
238-
if [[ $loop_count -eq 60 ]] ; then
239-
echo "ERROR: timeout waiting for logcat process $LOGCAT_PID to terminate" >&2
240-
exit 1
241-
fi
242-
243-
echo "Waiting for logcat process $LOGCAT_PID to terminate"
244-
sleep 1
245-
done
246-
247-
echo "logcat process $LOGCAT_PID has been successfully terminated"
248-
249-
- name: Firebase Auth Emulator Stop
250-
continue-on-error: true
251-
run: |
252-
set -euo pipefail
253-
254-
echo "Sending SIGINT to Firebase Auth Emulator process $FIREBASE_AUTH_EMULATOR_PID"
255-
kill -s SIGINT "$FIREBASE_AUTH_EMULATOR_PID"
256-
257-
loop_count=0
258-
while kill -0 "$FIREBASE_AUTH_EMULATOR_PID" ; do
259-
loop_count=$((loop_count+1))
260-
if [[ $loop_count -eq 60 ]] ; then
261-
echo "ERROR: timeout waiting for Firebase Auth Emulator process $FIREBASE_AUTH_EMULATOR_PID to terminate" >&2
262-
exit 1
263-
fi
264-
265-
echo "Waiting for Firebase Auth Emulator process $FIREBASE_AUTH_EMULATOR_PID to terminate"
266-
sleep 1
267-
done
268-
269-
echo "Firebase Auth Emulator process $FIREBASE_AUTH_EMULATOR_PID has been successfully terminated"
270-
271-
- name: Data Connect Emulator Stop
272-
continue-on-error: true
273-
run: |
274-
set -euo pipefail
275-
276-
echo "Sending SIGINT to Firebase Data Connect Emulator process $FIREBASE_DATA_CONNECT_EMULATOR_PID"
277-
kill -s SIGINT "$FIREBASE_DATA_CONNECT_EMULATOR_PID"
278-
279-
loop_count=0
280-
while kill -0 "$FIREBASE_DATA_CONNECT_EMULATOR_PID" ; do
281-
loop_count=$((loop_count+1))
282-
if [[ $loop_count -eq 60 ]] ; then
283-
echo "ERROR: timeout waiting for Firebase Data Connect Emulator process $FIREBASE_DATA_CONNECT_EMULATOR_PID to terminate" >&2
284-
exit 1
285-
fi
286-
287-
echo "Waiting for Firebase Data Connect Emulator process $FIREBASE_DATA_CONNECT_EMULATOR_PID to terminate"
288-
sleep 1
289-
done
290-
291-
echo "Firebase Data Connect Emulator process $FIREBASE_DATA_CONNECT_EMULATOR_PID has been successfully terminated"
292-
293226
- name: Upload Log Files
294227
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4.6.1
295228
with:

0 commit comments

Comments
 (0)