Skip to content

Commit 8ad9ef5

Browse files
authored
Include message priority when logging to Firelog. (#6227)
1 parent 829dab3 commit 8ad9ef5

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

firebase-messaging/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Unreleased
2-
2+
* [changed] Included message priority when logging to Firelog.
33

44
# 24.0.1
55
* [changed] Retry Topic Subscribe/Unsubscribe operations with exponential

firebase-messaging/src/main/java/com/google/firebase/messaging/MessagingAnalytics.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,8 @@ static MessagingClientEvent eventToProto(MessagingClientEvent.Event event, Inten
576576
.setInstanceId(getInstanceId(extras))
577577
.setPackageName(getPackageName())
578578
.setSdkPlatform(MessagingClientEvent.SDKPlatform.ANDROID)
579-
.setMessageType(getMessageTypeForFirelog(extras));
579+
.setMessageType(getMessageTypeForFirelog(extras))
580+
.setPriority(getMessagePriorityForFirelog(extras));
580581

581582
// nullable parameters
582583
String messageId = getMessageId(extras);

firebase-messaging/src/test/java/com/google/firebase/messaging/MessagingAnalyticsRoboTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,10 @@ public class MessagingAnalyticsRoboTest {
6868
// Copy from FirebaseMessagingService so the tests break if the constants are changed
6969
// TODO(dgiorgini) instead of copy&paste create a test to verify the original constants
7070
static final String ANALYTICS_PREFIX = "google.c.a.";
71-
static final String ANALYTICS_ENABLED = ANALYTICS_PREFIX + "e";
7271
static final String ANALYTICS_COMPOSER_ID = ANALYTICS_PREFIX + "c_id";
7372
static final String ANALYTICS_COMPOSER_LABEL = ANALYTICS_PREFIX + "c_l";
7473
static final String ANALYTICS_MESSAGE_TIMESTAMP = ANALYTICS_PREFIX + "ts";
75-
static final String ANALYTICS_MESSAGE_USE_DEVICE_TIME = ANALYTICS_PREFIX + "udt";
7674
static final String ANALYTICS_TRACK_CONVERSIONS = ANALYTICS_PREFIX + "tc";
77-
static final String ANALYTICS_ABT_EXPERIMENT = ANALYTICS_PREFIX + "abt";
7875
static final String ANALYTICS_MESSAGE_LABEL = ANALYTICS_PREFIX + "m_l";
7976

8077
// Copy from MessagingAnalytics so the tests break if the constants are changed
@@ -997,7 +994,7 @@ public void testEventToProto_fullSampleTopicMessage() {
997994
b.putString(MessagePayloadKeys.FROM, "/topics/my cool topic");
998995
b.putString(MessageNotificationKeys.ENABLE_NOTIFICATION, "1");
999996
b.putString(MessagePayloadKeys.MSGID, "an id!!!");
1000-
b.putString(MessagePayloadKeys.DELIVERED_PRIORITY, "high");
997+
b.putString(MessagePayloadKeys.DELIVERED_PRIORITY, "normal");
1001998
b.putString(MessagePayloadKeys.SENDER_ID, "100101010");
1002999
b.putString(AnalyticsKeys.COMPOSER_LABEL, "composer label!");
10031000
b.putString(AnalyticsKeys.MESSAGE_LABEL, "message label!");
@@ -1016,6 +1013,7 @@ public void testEventToProto_fullSampleTopicMessage() {
10161013
assertThat(ev.getInstanceId()).isEqualTo("some_installation_id");
10171014
assertThat(ev.getEvent()).isEqualTo(MessagingClientEvent.Event.MESSAGE_DELIVERED);
10181015
assertThat(ev.getTtl()).isEqualTo(22223L);
1016+
assertThat(ev.getPriority()).isEqualTo(5);
10191017
assertThat(ev.getTopic()).isEqualTo("/topics/my cool topic");
10201018
assertThat(ev.getAnalyticsLabel()).isEqualTo("message label!");
10211019
assertThat(ev.getComposerLabel()).isEqualTo("composer label!");
@@ -1049,6 +1047,7 @@ public void testEventToProto_fullSampleDirectedMessage() {
10491047
assertThat(ev.getInstanceId()).isEqualTo("some_installation_id");
10501048
assertThat(ev.getEvent()).isEqualTo(MessagingClientEvent.Event.MESSAGE_DELIVERED);
10511049
assertThat(ev.getTtl()).isEqualTo(22223L);
1050+
assertThat(ev.getPriority()).isEqualTo(10);
10521051
assertThat(ev.getTopic()).isEmpty();
10531052
assertThat(ev.getAnalyticsLabel()).isEqualTo("message label!");
10541053
assertThat(ev.getComposerLabel()).isEqualTo("composer label!");

0 commit comments

Comments
 (0)