Include message priority when logging to Firelog. #6227

gsakakihara · 2024-09-04T21:01:03Z

No description provided.

github-actions · 2024-09-04T21:01:19Z

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes

firebase-messaging

### {{messaging_longer}} version 24.0.2 {: #messaging_v24-0-2}

* {{changed}} Included message priority when logging to Firelog.

#### {{messaging_longer}} Kotlin extensions version 24.0.2 {: #messaging-ktx_v24-0-2}

The Kotlin extensions library transitively includes the updated
`firebase-messaging` library. The Kotlin extensions library has no additional
updates.

google-oss-bot · 2024-09-04T21:10:22Z

Size Report ¹

Affected Products

firebase-messaging
Type Base (b994bd4) Merge (509d4c1) Diff
aar 148 kB 148 kB +23 B (+0.0%)
apk (aggressive) 578 kB 578 kB +264 B (+0.0%)
apk (release) 5.30 MB 5.30 MB +16 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/6VACIYi0fy.html

github-actions · 2024-09-04T21:11:55Z

Unit Test Results

  64 files +  26   64 suites +26 6m 14s ⏱️ + 5m 5s
487 tests +392 487 ✔️ +392 0 💤 ±0 0 ❌ ±0
980 runs +790 980 ✔️ +790 0 💤 ±0 0 ❌ ±0

Results for commit a3d4e97. ± Comparison against base commit b994bd4.

This pull request removes 95 and adds 487 tests. Note that renamed tests count towards both.

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…

google-oss-bot · 2024-09-04T21:13:28Z

Coverage Report ¹

Affected Products

firebase-messaging
Overall coverage changed from 84.09% (b994bd4) to 84.13% (509d4c1) by +0.04%.
Filename Base (b994bd4) Merge (509d4c1) Diff
FirebaseMessaging.java 76.00% 75.60% -0.40%
MessagingAnalytics.java 82.80% 82.87% +0.07%
MessagingClientEvent.java 93.58% 95.41% +1.83%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/g3ye2YVoNS.html

google-oss-bot · 2024-09-04T21:28:18Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (b994bd4) and the CI merge commit (509d4c1)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- b994bd4: https://storage.googleapis.com/firebase-sdk-metric-reports/GXFhIFo1un/index.html
- 509d4c1: https://storage.googleapis.com/firebase-sdk-metric-reports/P67i6Kszfn/index.html

Startup Times

`fire-fcm`

Device Statistics Distributions

oriole-32

Percentile	`b994bd4`	`509d4c1`	Diff	Significant (?)
p10	1.20 ±1 ms	1.36 ±0.8 ms	+152 μs (+12.6%)	NO
p25	1.29 ±1 ms	1.45 ±0.9 ms	+160 μs (+12.4%)	NO
p50	1.46 ±1 ms	1.63 ±0.9 ms	+170 μs (+11.6%)	NO
p75	1.69 ±2 ms	1.90 ±1 ms	+214 μs (+12.7%)	NO
p90	2.02 ±2 ms	2.33 ±1 ms	+303 μs (+15.0%)	NO

20 test runs in comparison

Commit	Test Runs
`b994bd4`	2024-09-04_18:38:51.328458_SeaY 2024-09-04_18:38:51.328501_zJsV 2024-09-04_18:38:51.328510_rcZt 2024-09-04_18:38:51.328518_ERgz 2024-09-04_18:38:51.328525_dYXt 2024-09-04_18:38:51.328532_dPOq 2024-09-04_18:38:51.328539_PfmB 2024-09-04_18:38:51.328546_jnZp 2024-09-04_18:38:51.328552_uZzC 2024-09-04_18:38:51.328565_xyIw
`509d4c1`	2024-09-04_21:14:19.253788_kUft 2024-09-04_21:14:19.253832_QQvQ 2024-09-04_21:14:19.253843_WwvW 2024-09-04_21:14:19.253850_Touf 2024-09-04_21:14:19.253857_kovw 2024-09-04_21:14:19.253864_bjAX 2024-09-04_21:14:19.253871_WTsM 2024-09-04_21:14:19.253888_BasR 2024-09-04_21:14:19.253896_AsNv 2024-09-04_21:14:19.253903_UFlX

redfin-30

Percentile	`b994bd4`	`509d4c1`	Diff	Significant (?)
p10	1.35 ±1 ms	1.39 ±0.9 ms	+39.2 μs (+2.9%)	NO
p25	1.61 ±1 ms	1.67 ±1 ms	+62.6 μs (+3.9%)	NO
p50	1.97 ±2 ms	2.03 ±2 ms	+62.0 μs (+3.1%)	NO
p75	2.53 ±2 ms	2.50 ±2 ms	-27.9 μs (-1.1%)	NO
p90	3.15 ±3 ms	3.25 ±3 ms	+100 μs (+3.2%)	NO

20 test runs in comparison

Commit	Test Runs
`b994bd4`	2024-09-04_18:38:51.328458_SeaY 2024-09-04_18:38:51.328501_zJsV 2024-09-04_18:38:51.328510_rcZt 2024-09-04_18:38:51.328518_ERgz 2024-09-04_18:38:51.328525_dYXt 2024-09-04_18:38:51.328532_dPOq 2024-09-04_18:38:51.328539_PfmB 2024-09-04_18:38:51.328546_jnZp 2024-09-04_18:38:51.328552_uZzC 2024-09-04_18:38:51.328565_xyIw
`509d4c1`	2024-09-04_21:14:19.253788_kUft 2024-09-04_21:14:19.253832_QQvQ 2024-09-04_21:14:19.253843_WwvW 2024-09-04_21:14:19.253850_Touf 2024-09-04_21:14:19.253857_kovw 2024-09-04_21:14:19.253864_bjAX 2024-09-04_21:14:19.253871_WTsM 2024-09-04_21:14:19.253888_BasR 2024-09-04_21:14:19.253896_AsNv 2024-09-04_21:14:19.253903_UFlX

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`b994bd4`	`509d4c1`	Diff	Significant (?)
p10	203 ±6 ms	204 ±3 ms	+627 μs (+0.3%)	NO
p25	210 ±9.7 ms	210 ±3 ms	-215 μs (-0.1%)	NO
p50	218 ±13 ms	217 ±3 ms	-840 μs (-0.4%)	NO
p75	228 ±21 ms	226 ±3 ms	-2.31 ms (-1.0%)	NO
p90	238 ±24 ms	241 ±7 ms	+3.03 ms (+1.3%)	NO

20 test runs in comparison

Commit	Test Runs
`b994bd4`	2024-09-04_18:38:51.328458_SeaY 2024-09-04_18:38:51.328501_zJsV 2024-09-04_18:38:51.328510_rcZt 2024-09-04_18:38:51.328518_ERgz 2024-09-04_18:38:51.328525_dYXt 2024-09-04_18:38:51.328532_dPOq 2024-09-04_18:38:51.328539_PfmB 2024-09-04_18:38:51.328546_jnZp 2024-09-04_18:38:51.328552_uZzC 2024-09-04_18:38:51.328565_xyIw
`509d4c1`	2024-09-04_21:14:19.253788_kUft 2024-09-04_21:14:19.253832_QQvQ 2024-09-04_21:14:19.253843_WwvW 2024-09-04_21:14:19.253850_Touf 2024-09-04_21:14:19.253857_kovw 2024-09-04_21:14:19.253864_bjAX 2024-09-04_21:14:19.253871_WTsM 2024-09-04_21:14:19.253888_BasR 2024-09-04_21:14:19.253896_AsNv 2024-09-04_21:14:19.253903_UFlX

redfin-30

Percentile	`b994bd4`	`509d4c1`	Diff	Significant (?)
p10	244 ±4 ms	266 ±6 ms	+21.5 ms (+8.8%)	MAYBE
p25	250 ±5 ms	273 ±6 ms	+22.3 ms (+8.9%)	MAYBE
p50	257 ±4 ms	280 ±7 ms	+22.7 ms (+8.8%)	MAYBE
p75	265 ±4 ms	289 ±6 ms	+23.8 ms (+9.0%)	MAYBE
p90	277 ±6 ms	310 ±7 ms	+33.1 ms (+12.0%)	YES

20 test runs in comparison

Commit	Test Runs
`b994bd4`	2024-09-04_18:38:51.328458_SeaY 2024-09-04_18:38:51.328501_zJsV 2024-09-04_18:38:51.328510_rcZt 2024-09-04_18:38:51.328518_ERgz 2024-09-04_18:38:51.328525_dYXt 2024-09-04_18:38:51.328532_dPOq 2024-09-04_18:38:51.328539_PfmB 2024-09-04_18:38:51.328546_jnZp 2024-09-04_18:38:51.328552_uZzC 2024-09-04_18:38:51.328565_xyIw
`509d4c1`	2024-09-04_21:14:19.253788_kUft 2024-09-04_21:14:19.253832_QQvQ 2024-09-04_21:14:19.253843_WwvW 2024-09-04_21:14:19.253850_Touf 2024-09-04_21:14:19.253857_kovw 2024-09-04_21:14:19.253864_bjAX 2024-09-04_21:14:19.253871_WTsM 2024-09-04_21:14:19.253888_BasR 2024-09-04_21:14:19.253896_AsNv 2024-09-04_21:14:19.253903_UFlX

https://storage.googleapis.com/firebase-sdk-metric-reports/agZYopIJex/index.html

Include message priority when logging to Firelog.

a3d4e97

google-oss-bot added the size/S label Sep 4, 2024

gsakakihara requested review from welishr and willxu-google September 4, 2024 21:27

welishr approved these changes Sep 9, 2024

View reviewed changes

gsakakihara merged commit 8ad9ef5 into main Sep 10, 2024
38 checks passed

gsakakihara deleted the gsakakihara/priority branch September 10, 2024 14:57

firebase locked and limited conversation to collaborators Oct 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Include message priority when logging to Firelog. #6227

Include message priority when logging to Firelog. #6227

Uh oh!

gsakakihara commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Sep 4, 2024

`firebase-messaging`

Uh oh!

github-actions bot commented Sep 4, 2024

Uh oh!

google-oss-bot commented Sep 4, 2024

`firebase-messaging`

Uh oh!

google-oss-bot commented Sep 4, 2024

`fire-fcm`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Uh oh!

Include message priority when logging to Firelog. #6227

Include message priority when logging to Firelog. #6227

Uh oh!

Conversation

gsakakihara commented Sep 4, 2024

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note changes

Uh oh!

google-oss-bot commented Sep 4, 2024

Size Report 1

Affected Products

firebase-messaging

Test Logs

Uh oh!

github-actions bot commented Sep 4, 2024

Unit Test Results

Uh oh!

google-oss-bot commented Sep 4, 2024

Coverage Report 1

Affected Products

firebase-messaging

Test Logs

Uh oh!

google-oss-bot commented Sep 4, 2024

Startup Time Report 1

Notes

Startup Times

fire-fcm

timeToInitialDisplay

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2024 •

edited

Loading

Size Report ¹

`firebase-messaging`

Coverage Report ¹

`firebase-messaging`

Startup Time Report ¹

`fire-fcm`

`timeToInitialDisplay`