Skip to content

Commit 962db55

Browse files
committed
Merge branch 'master' into realtime-rc-merge
2 parents 465488e + 7355e88 commit 962db55

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

firebase-appdistribution-api/api.txt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ package com.google.firebase.appdistribution {
2424
}
2525

2626
public class FirebaseAppDistributionException extends com.google.firebase.FirebaseException {
27-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status);
28-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status, @Nullable com.google.firebase.appdistribution.AppDistributionRelease);
29-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status, @NonNull Throwable);
30-
ctor public FirebaseAppDistributionException(@NonNull String, @NonNull com.google.firebase.appdistribution.FirebaseAppDistributionException.Status, @Nullable com.google.firebase.appdistribution.AppDistributionRelease, @NonNull Throwable);
3127
method @NonNull public com.google.firebase.appdistribution.FirebaseAppDistributionException.Status getErrorCode();
3228
method @Nullable public com.google.firebase.appdistribution.AppDistributionRelease getRelease();
3329
}
@@ -50,8 +46,8 @@ package com.google.firebase.appdistribution {
5046
}
5147

5248
public interface UpdateProgress {
53-
method @NonNull public long getApkBytesDownloaded();
54-
method @NonNull public long getApkFileTotalBytes();
49+
method public long getApkBytesDownloaded();
50+
method public long getApkFileTotalBytes();
5551
method @NonNull public com.google.firebase.appdistribution.UpdateStatus getUpdateStatus();
5652
}
5753

firebase-appdistribution-api/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistributionException.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,22 +83,26 @@ public enum Status {
8383
@NonNull private final Status status;
8484
@Nullable private final AppDistributionRelease release;
8585

86+
/** @hide */
8687
public FirebaseAppDistributionException(@NonNull String message, @NonNull Status status) {
8788
this(message, status, (AppDistributionRelease) null);
8889
}
8990

91+
/** @hide */
9092
public FirebaseAppDistributionException(
9193
@NonNull String message, @NonNull Status status, @Nullable AppDistributionRelease release) {
9294
super(message);
9395
this.status = status;
9496
this.release = release;
9597
}
9698

99+
/** @hide */
97100
public FirebaseAppDistributionException(
98101
@NonNull String message, @NonNull Status status, @NonNull Throwable cause) {
99102
this(message, status, null, cause);
100103
}
101104

105+
/** @hide */
102106
public FirebaseAppDistributionException(
103107
@NonNull String message,
104108
@NonNull Status status,

firebase-messaging/src/main/java/com/google/firebase/messaging/FcmExecutors.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
class FcmExecutors {
3535
// TODO(b/117848373): TikTok applications need to comply with go/tiktok-tattletale. Before we
3636
// migrate to use TikTok thread pools, threads need to use the whitelisted prefix
37-
// "Firebase-Messaing".
37+
// "Firebase-Messaging".
3838
private static final String THREAD_NETWORK_IO = "Firebase-Messaging-Network-Io";
3939
private static final String THREAD_TASK = "Firebase-Messaging-Task";
4040
private static final String THREAD_FILE = "Firebase-Messaging-File";

firebase-messaging/src/main/java/com/google/firebase/messaging/TopicOperation.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import androidx.annotation.StringDef;
2323
import androidx.annotation.VisibleForTesting;
2424
import com.google.android.gms.common.internal.Objects;
25+
import java.lang.annotation.Retention;
26+
import java.lang.annotation.RetentionPolicy;
2527
import java.util.regex.Pattern;
2628

2729
final class TopicOperation {
@@ -117,6 +119,7 @@ public int hashCode() {
117119
}
118120

119121
@StringDef({TopicOperations.OPERATION_SUBSCRIBE, TopicOperations.OPERATION_UNSUBSCRIBE})
122+
@Retention(RetentionPolicy.SOURCE)
120123
@interface TopicOperations {
121124
String OPERATION_SUBSCRIBE = "S";
122125
String OPERATION_UNSUBSCRIBE = "U";

0 commit comments

Comments
 (0)