Skip to content

Commit 7355e88

Browse files
authored
Add @retention to TopicOperation.TopicOperations annotation. (#3746)
#3740 * Added @retention(RetentionPolicy.SOURCE) to TopicOperation.TopicOperations annotation declaration to avoid having it included in the library. * Also fixed a typo in FcmExecutors.
1 parent 8a21319 commit 7355e88

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

firebase-messaging/src/main/java/com/google/firebase/messaging/FcmExecutors.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
class FcmExecutors {
3535
// TODO(b/117848373): TikTok applications need to comply with go/tiktok-tattletale. Before we
3636
// migrate to use TikTok thread pools, threads need to use the whitelisted prefix
37-
// "Firebase-Messaing".
37+
// "Firebase-Messaging".
3838
private static final String THREAD_NETWORK_IO = "Firebase-Messaging-Network-Io";
3939
private static final String THREAD_TASK = "Firebase-Messaging-Task";
4040
private static final String THREAD_FILE = "Firebase-Messaging-File";

firebase-messaging/src/main/java/com/google/firebase/messaging/TopicOperation.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import androidx.annotation.StringDef;
2323
import androidx.annotation.VisibleForTesting;
2424
import com.google.android.gms.common.internal.Objects;
25+
import java.lang.annotation.Retention;
26+
import java.lang.annotation.RetentionPolicy;
2527
import java.util.regex.Pattern;
2628

2729
final class TopicOperation {
@@ -117,6 +119,7 @@ public int hashCode() {
117119
}
118120

119121
@StringDef({TopicOperations.OPERATION_SUBSCRIBE, TopicOperations.OPERATION_UNSUBSCRIBE})
122+
@Retention(RetentionPolicy.SOURCE)
120123
@interface TopicOperations {
121124
String OPERATION_SUBSCRIBE = "S";
122125
String OPERATION_UNSUBSCRIBE = "U";

0 commit comments

Comments
 (0)