Skip to content

Add @Retention to TopicOperation.TopicOperations annotation. #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

Add @Retention to TopicOperation.TopicOperations annotation. #3746

merged 1 commit into from
May 26, 2022

Conversation

gsakakihara
Copy link
Contributor

#3740

  • Added @retention(RetentionPolicy.SOURCE) to TopicOperation.TopicOperations annotation declaration to avoid having it included in the library.
  • Also fixed a typo in FcmExecutors.

@gsakakihara
Add @retention to TopicOperation.TopicOperations annotation.
b79c8fa 
#3740
* Added @retention(RetentionPolicy.SOURCE) to TopicOperation.TopicOperations annotation declaration to avoid having it included in the library.
* Also fixed a typo in FcmExecutors.
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.83% (bd761a7) to 84.91% (59b678c) by +0.08%.

    FilenameBase (bd761a7)Merge (59b678c)Diff
    MessagingAnalytics.java81.38%82.19%+0.81%

Test Logs

Notes

  • Commit (59b678c) is created by Prow via merging PR base commit (bd761a7) and head commit (b79c8fa).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/joZyOwxnJD.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (bd761a7)Merge (59b678c)Diff
    aar142 kB142 kB-21 B (-0.0%)
    apk (aggressive)437 kB437 kB-60 B (-0.0%)
    apk (release)1.14 MB1.14 MB+36 B (+0.0%)

Test Logs

Notes

  • Commit (59b678c) is created by Prow via merging PR base commit (bd761a7) and head commit (b79c8fa).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PVYP0XyTWm.html

@gsakakihara gsakakihara requested review from VinayGuthal, welishr, willxu-google and James201311 and removed request for VinayGuthal May 25, 2022 23:04
@gsakakihara gsakakihara merged commit 7355e88 into master May 26, 2022
@gsakakihara gsakakihara deleted the gsakakihara/retention_annotation branch May 26, 2022 14:45
James201311
James201311 reviewed May 26, 2022
View reviewed changes
firebase-messaging/src/main/java/com/google/firebase/messaging/TopicOperation.java
Comment on lines 124 to 125
String OPERATION_SUBSCRIBE = "S";
String OPERATION_UNSUBSCRIBE = "U";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these two values be discarded at compile time if we add “SOURCE” Retention policy?
If so, we might need to pull these two string out.

@firebase firebase locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@James201311 James201311 James201311 left review comments

@willxu-google willxu-google willxu-google approved these changes

@welishr welishr Awaiting requested review from welishr

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsakakihara @google-oss-bot @James201311 @willxu-google