Update AnnotationBuilder to not rely on toString() (#2725)

* Update AnnotationBuilder to not rely on toString()

The toString() implementation of enum constants in annotations changed in JDK-8164819, this makes the previous behaviour more explicit.

* Fix test.

Author: rlazo

encoders/firebase-encoders-processor/src/main/java/com/google/firebase/encoders/processor/annotations/AnnotationBuilder.java

@@ -32,7 +32,9 @@
 import javax.lang.model.element.ExecutableElement;
 import javax.lang.model.element.Modifier;
 import javax.lang.model.element.TypeElement;
+import javax.lang.model.element.VariableElement;
 import javax.lang.model.util.ElementFilter;
+import javax.lang.model.util.SimpleAnnotationValueVisitor8;
 
 /**
  * Generates an annotation implementation.
@@ -123,7 +125,21 @@ private static TypeSpec createBuilder(
           FieldSpec.builder(field.type, field.name).addModifiers(Modifier.PRIVATE);
       AnnotationValue value = annotationImpl.defaults.get(field);
       if (value != null) {
-        fieldSpec.initializer("$L", value);
+        new SimpleAnnotationValueVisitor8<Void, Void>() {
+          @Override
+          public Void visitEnumConstant(VariableElement c, Void unused) {
+            // Using $L would print the simple name of the enum constant in JDK 17,
+            // see: https://github.com/square/javapoet/issues/845
+            fieldSpec.initializer("$T.$L", c.asType(), c.getSimpleName());
+            return null;
+          }
+
+          @Override
+          protected Void defaultAction(Object o, Void unused) {
+            fieldSpec.initializer("$L", value);
+            return null;
+          }
+        }.visit(value, null);
       }
       annotationBuilder.addMethod(
           MethodSpec.methodBuilder(field.name)

encoders/firebase-encoders-processor/src/test/resources/ExpectedAtMyAnnotation.java

@@ -38,7 +38,7 @@ public final class AtMyAnnotation {
 
   private String strVal = "default";
 
-  private MyAnnotation.MyEnum enumVal = com.example.MyAnnotation.MyEnum.VALUE1;
+  private MyAnnotation.MyEnum enumVal = MyAnnotation.MyEnum.VALUE1;
 
   public AtMyAnnotation intVal(int intVal) {
     this.intVal = intVal;
@@ -224,4 +224,4 @@ public String toString() {
       return sb.toString();
     }
   }
-}
+}