Skip to content

Update AnnotationBuilder to not rely on toString() #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2021
Merged

Update AnnotationBuilder to not rely on toString() #2725

merged 2 commits into from
Jun 11, 2021

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 10, 2021

The toString() implementation of enum constants in annotations changed in JDK-8164819, this makes the previous behaviour more explicit.

@rlazo
Update AnnotationBuilder to not rely on toString()
3f829a6 
The toString() implementation of enum constants in annotations changed in JDK-8164819, this makes the previous behaviour more explicit.
@rlazo rlazo requested a review from vkryachko June 10, 2021 02:54
@googlebot googlebot added the cla: yes Override cla label Jun 10, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 10, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (b2112eb) and head commit (eef0e2d4).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (eef0e2d4) is created by Prow via merging commits: b2112eb 96eda3c.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 10, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (b2112eb) and head commit (eef0e2d4).

Test Logs

Notes

Head commit (eef0e2d4) is created by Prow via merging commits: b2112eb 96eda3c.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 10, 2021 •
edited
Loading

Macrobenchmark Report

Affected SDKs

Measurements are for head commit (96eda3c). Diffing against base commit (b2112eb) is working in progress.

  • baseline

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait130.0 ms198.0 ms143.0 ms154.1 ms189.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms66.0 ms47.5 ms60.5 ms65.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait57.0 ms93.0 ms75.5 ms87.2 ms92.2 ms

  • firebase-common

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait131.0 ms190.0 ms147.5 ms166.2 ms185.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait39.0 ms67.0 ms51.5 ms63.3 ms66.8 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait60.0 ms88.0 ms75.5 ms84.0 ms87.2 ms

  • firebase-config

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait131.0 ms182.0 ms148.0 ms162.9 ms179.9 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait39.0 ms72.0 ms48.0 ms60.1 ms69.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait52.0 ms88.0 ms71.5 ms84.2 ms87.6 ms

  • firebase-crashlytics

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait131.0 ms183.0 ms155.5 ms174.2 ms181.7 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait43.0 ms62.0 ms51.0 ms57.1 ms61.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait58.0 ms100.0 ms70.0 ms89.5 ms98.9 ms

  • firebase-database

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms163.0 ms146.5 ms156.3 ms162.2 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait36.0 ms66.0 ms53.0 ms62.2 ms65.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait56.0 ms92.0 ms76.0 ms90.0 ms91.6 ms

  • firebase-dynamic-links

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait122.0 ms158.0 ms139.5 ms155.2 ms157.8 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait37.0 ms73.0 ms57.0 ms61.4 ms71.5 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait52.0 ms88.0 ms67.0 ms80.5 ms87.4 ms

  • firebase-firestore

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait125.0 ms161.0 ms136.5 ms151.7 ms160.4 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait42.0 ms68.0 ms48.0 ms61.0 ms66.7 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait51.0 ms83.0 ms69.5 ms79.2 ms82.6 ms

  • firebase-functions

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait126.0 ms164.0 ms142.5 ms159.2 ms163.4 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait42.0 ms70.0 ms58.0 ms64.2 ms69.2 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait52.0 ms91.0 ms77.5 ms86.1 ms90.2 ms

  • firebase-inappmessaging-display

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait166.0 ms213.0 ms194.5 ms206.0 ms211.7 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait40.0 ms74.0 ms54.0 ms66.2 ms72.9 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait64.0 ms104.0 ms83.0 ms95.0 ms102.3 ms

  • firebase-messaging

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait128.0 ms193.0 ms150.0 ms167.6 ms189.2 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait39.0 ms75.0 ms55.5 ms62.2 ms74.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait57.0 ms92.0 ms75.0 ms90.1 ms91.8 ms

  • firebase-perf

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait135.0 ms175.0 ms148.5 ms163.2 ms173.1 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait48.0 ms65.0 ms57.0 ms63.0 ms64.6 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait43.0 ms83.0 ms75.0 ms82.1 ms83.0 ms

  • firebase-storage

    NameDeviceMinMaxP50P90P99
    BenchmarkTest.startup[mode=COLD]flame-30-en-portrait121.0 ms162.0 ms143.0 ms153.7 ms161.6 ms
    BenchmarkTest.startup[mode=HOT]flame-30-en-portrait42.0 ms63.0 ms50.5 ms57.1 ms62.0 ms
    BenchmarkTest.startup[mode=WARM]flame-30-en-portrait54.0 ms96.0 ms67.5 ms83.3 ms94.1 ms

@vkryachko
Copy link
Member

Looks like this is introducing a regression:

com/example/AtMyAnnotation.java:25: error: illegal start of expression
  private String strVal = default;

So I think for correctness we need to at least add visitString, and add tests that verify that other possible types work as expected

@rlazo
Copy link
Collaborator Author

rlazo commented Jun 10, 2021

/test check-changed

@rlazo
Copy link
Collaborator Author

rlazo commented Jun 11, 2021

Looks like this is introducing a regression:

com/example/AtMyAnnotation.java:25: error: illegal start of expression
  private String strVal = default;

So I think for correctness we need to at least add visitString, and add tests that verify that other possible types work as expected

FIxed. PTAL

@rlazo rlazo merged commit 98e066a into master Jun 11, 2021
@rlazo rlazo deleted the rl.enuman91832 branch June 11, 2021 14:34
@firebase firebase locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @vkryachko @googlebot