Skip to content

Commit b39de05

Browse files
authored
Add more tests with filters on the same field (#5041)
* Add more tests
1 parent 2d2e008 commit b39de05

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteIndexManagerTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,7 @@ public void testCursorsDoNoExpandResultSet() {
627627
@Test
628628
public void testFiltersOnTheSameField() {
629629
indexManager.addFieldIndex(fieldIndex("coll", "a", Kind.ASCENDING));
630+
indexManager.addFieldIndex(fieldIndex("coll", "a", Kind.ASCENDING, "b", Kind.ASCENDING));
630631

631632
addDoc("coll/val1", map("a", 1, "b", 1));
632633
addDoc("coll/val2", map("a", 2, "b", 2));
@@ -654,6 +655,14 @@ public void testFiltersOnTheSameField() {
654655
.orderBy(orderBy("a"))
655656
.orderBy(orderBy(DocumentKey.KEY_FIELD_NAME, "desc"));
656657
verifyResults(query, "coll/val2");
658+
659+
query =
660+
query("coll")
661+
.filter(filter("a", ">", 1))
662+
.filter(filter("a", "==", 3))
663+
.orderBy(orderBy("a"))
664+
.orderBy(orderBy("b"));
665+
verifyResults(query, "coll/val3");
657666
}
658667

659668
@Test

firebase-firestore/src/test/java/com/google/firebase/firestore/model/TargetIndexMatcherTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -602,9 +602,8 @@ public void withEqualityAndInequalityOnTheSameField() {
602602
query("collId")
603603
.filter(filter("a", ">=", 5))
604604
.filter(filter("a", "==", 0))
605-
.filter(filter("b", "==", 0))
606-
.orderBy(orderBy("a", "desc"))
607-
.orderBy(orderBy(DocumentKey.KEY_FIELD_NAME, "desc")),
605+
.orderBy(orderBy("a", "asc"))
606+
.orderBy(orderBy("b", "asc")),
608607
"a",
609608
FieldIndex.Segment.Kind.ASCENDING,
610609
"b",

0 commit comments

Comments
 (0)