Add more tests with filters on the same field #5041

wu-hui · 2023-05-30T13:46:23Z

No description provided.

# Conflicts: # firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteIndexManagerTest.java # firebase-firestore/src/test/java/com/google/firebase/firestore/model/TargetIndexMatcherTest.java

google-oss-bot · 2023-05-30T13:50:53Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2023-05-30T13:56:37Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 44.34% (2d2e008) to 44.33% (327b9f5) by -0.02%.
Filename Base (2d2e008) Merge (327b9f5) Diff
DeleteMutation.java 95.24% 90.48% -4.76%
LruGarbageCollector.java 97.27% 93.64% -3.64%
SetMutation.java 94.44% 97.22% +2.78%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/tL0eW7Nfuu.html

github-actions · 2023-05-30T13:57:59Z

Unit Test Results

  162 files ±0   162 suites ±0 2m 5s ⏱️ - 1m 48s
1 160 tests ±0 1 144 ✔️ ±0 16 💤 ±0 0 ❌ ±0
2 320 runs ±0 2 288 ✔️ ±0 32 💤 ±0 0 ❌ ±0

Results for commit 312b207. ± Comparison against base commit 2d2e008.

google-oss-bot · 2023-05-30T14:02:48Z

Size Report ¹

Affected Products

No changes between base commit (2d2e008) and merge commit (327b9f5).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/onJngAuodZ.html

cherylEnkidu

Thank you

google-oss-bot · 2023-05-30T14:26:24Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (2d2e008) and the CI merge commit (327b9f5)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 2d2e008: https://storage.googleapis.com/firebase-sdk-metric-reports/sjZhUH4urk/index.html
- 327b9f5: https://storage.googleapis.com/firebase-sdk-metric-reports/m5NqAFzSrb/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`2d2e008`	`327b9f5`	Diff	Significant (?)
p10	331 ±21 μs	320 ±13 μs	-11.3 μs (-3.4%)	NO
p25	345 ±29 μs	328 ±15 μs	-17.6 μs (-5.1%)	NO
p50	371 ±44 μs	341 ±19 μs	-29.4 μs (-7.9%)	NO
p75	426 ±95 μs	365 ±29 μs	-60.9 μs (-14.3%)	NO
p90	521 ±150 μs	437 ±78 μs	-84.4 μs (-16.2%)	NO

20 test runs in comparison

Commit	Test Runs
`2d2e008`	2023-05-26_18:28:18.960180_aGsy 2023-05-26_18:28:18.963846_rqCG 2023-05-26_18:28:18.963858_mxrf 2023-05-26_18:28:18.963865_lXyl 2023-05-26_18:28:18.963870_JpzB 2023-05-26_18:28:18.963877_eDMs 2023-05-26_18:28:18.963882_sjMJ 2023-05-26_18:28:18.963887_XcXB 2023-05-26_18:28:18.963894_LoyK 2023-05-26_18:28:18.963900_FjKh
`327b9f5`	2023-05-30_14:06:30.609177_PxiS 2023-05-30_14:06:30.612112_RWFi 2023-05-30_14:06:30.612126_NWkI 2023-05-30_14:06:30.612134_EoFh 2023-05-30_14:06:30.612140_wSTi 2023-05-30_14:06:30.612147_HTRj 2023-05-30_14:06:30.612153_wevj 2023-05-30_14:06:30.612159_YOuG 2023-05-30_14:06:30.612166_kJfk 2023-05-30_14:06:30.612172_zqwO

redfin-30

Percentile	`2d2e008`	`327b9f5`	Diff	Significant (?)
p10	643 ±34 μs	628 ±17 μs	-14.7 μs (-2.3%)	NO
p25	666 ±36 μs	650 ±28 μs	-16.3 μs (-2.5%)	NO
p50	695 ±43 μs	677 ±40 μs	-17.6 μs (-2.5%)	NO
p75	736 ±48 μs	714 ±61 μs	-21.6 μs (-2.9%)	NO
p90	799 ±68 μs	786 ±147 μs	-13.4 μs (-1.7%)	NO

20 test runs in comparison

Commit	Test Runs
`2d2e008`	2023-05-26_18:28:18.960180_aGsy 2023-05-26_18:28:18.963846_rqCG 2023-05-26_18:28:18.963858_mxrf 2023-05-26_18:28:18.963865_lXyl 2023-05-26_18:28:18.963870_JpzB 2023-05-26_18:28:18.963877_eDMs 2023-05-26_18:28:18.963882_sjMJ 2023-05-26_18:28:18.963887_XcXB 2023-05-26_18:28:18.963894_LoyK 2023-05-26_18:28:18.963900_FjKh
`327b9f5`	2023-05-30_14:06:30.609177_PxiS 2023-05-30_14:06:30.612112_RWFi 2023-05-30_14:06:30.612126_NWkI 2023-05-30_14:06:30.612134_EoFh 2023-05-30_14:06:30.612140_wSTi 2023-05-30_14:06:30.612147_HTRj 2023-05-30_14:06:30.612153_wevj 2023-05-30_14:06:30.612159_YOuG 2023-05-30_14:06:30.612166_kJfk 2023-05-30_14:06:30.612172_zqwO

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`2d2e008`	`327b9f5`	Diff	Significant (?)
p10	190 ±3 ms	199 ±8 ms	+8.82 ms (+4.6%)	NO
p25	195 ±3 ms	205 ±8 ms	+9.06 ms (+4.6%)	NO
p50	202 ±4 ms	213 ±9 ms	+10.3 ms (+5.1%)	NO
p75	211 ±5 ms	223 ±11 ms	+12.4 ms (+5.9%)	NO
p90	219 ±6 ms	242 ±23 ms	+23.3 ms (+10.6%)	NO

20 test runs in comparison

Commit	Test Runs
`2d2e008`	2023-05-26_18:28:18.960180_aGsy 2023-05-26_18:28:18.963846_rqCG 2023-05-26_18:28:18.963858_mxrf 2023-05-26_18:28:18.963865_lXyl 2023-05-26_18:28:18.963870_JpzB 2023-05-26_18:28:18.963877_eDMs 2023-05-26_18:28:18.963882_sjMJ 2023-05-26_18:28:18.963887_XcXB 2023-05-26_18:28:18.963894_LoyK 2023-05-26_18:28:18.963900_FjKh
`327b9f5`	2023-05-30_14:06:30.609177_PxiS 2023-05-30_14:06:30.612112_RWFi 2023-05-30_14:06:30.612126_NWkI 2023-05-30_14:06:30.612134_EoFh 2023-05-30_14:06:30.612140_wSTi 2023-05-30_14:06:30.612147_HTRj 2023-05-30_14:06:30.612153_wevj 2023-05-30_14:06:30.612159_YOuG 2023-05-30_14:06:30.612166_kJfk 2023-05-30_14:06:30.612172_zqwO

redfin-30

Percentile	`2d2e008`	`327b9f5`	Diff	Significant (?)
p10	231 ±4 ms	255 ±4 ms	+23.4 ms (+10.1%)	YES
p25	237 ±4 ms	261 ±3 ms	+23.8 ms (+10.0%)	YES
p50	245 ±4 ms	269 ±3 ms	+24.1 ms (+9.8%)	YES
p75	253 ±4 ms	278 ±5 ms	+25.0 ms (+9.9%)	YES
p90	262 ±5 ms	292 ±9 ms	+29.9 ms (+11.4%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`2d2e008`	2023-05-26_18:28:18.960180_aGsy 2023-05-26_18:28:18.963846_rqCG 2023-05-26_18:28:18.963858_mxrf 2023-05-26_18:28:18.963865_lXyl 2023-05-26_18:28:18.963870_JpzB 2023-05-26_18:28:18.963877_eDMs 2023-05-26_18:28:18.963882_sjMJ 2023-05-26_18:28:18.963887_XcXB 2023-05-26_18:28:18.963894_LoyK 2023-05-26_18:28:18.963900_FjKh
`327b9f5`	2023-05-30_14:06:30.609177_PxiS 2023-05-30_14:06:30.612112_RWFi 2023-05-30_14:06:30.612126_NWkI 2023-05-30_14:06:30.612134_EoFh 2023-05-30_14:06:30.612140_wSTi 2023-05-30_14:06:30.612147_HTRj 2023-05-30_14:06:30.612153_wevj 2023-05-30_14:06:30.612159_YOuG 2023-05-30_14:06:30.612166_kJfk 2023-05-30_14:06:30.612172_zqwO

https://storage.googleapis.com/firebase-sdk-metric-reports/3hajU83tGy/index.html

wu-hui added 3 commits May 25, 2023 11:24

Fix equality and inequality on the same field

39af874

Add more tests

303f420

Merge branch 'master' into wuandy/FiltersOnSameField

312b207

# Conflicts: # firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteIndexManagerTest.java # firebase-firestore/src/test/java/com/google/firebase/firestore/model/TargetIndexMatcherTest.java

wu-hui requested a review from cherylEnkidu May 30, 2023 13:50

wu-hui assigned cherylEnkidu May 30, 2023

cherylEnkidu approved these changes May 30, 2023

View reviewed changes

wu-hui merged commit b39de05 into master May 30, 2023

wu-hui deleted the wuandy/FiltersOnSameField branch May 30, 2023 14:38

firebase locked and limited conversation to collaborators Jun 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add more tests with filters on the same field #5041

Add more tests with filters on the same field #5041

Uh oh!

wu-hui commented May 30, 2023

Uh oh!

google-oss-bot commented May 30, 2023

Uh oh!

google-oss-bot commented May 30, 2023

`firebase-firestore`

Uh oh!

github-actions bot commented May 30, 2023

Uh oh!

google-oss-bot commented May 30, 2023

Uh oh!

cherylEnkidu left a comment

Uh oh!

google-oss-bot commented May 30, 2023

`fire-fst`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Add more tests with filters on the same field #5041

Add more tests with filters on the same field #5041

Uh oh!

Conversation

wu-hui commented May 30, 2023

Uh oh!

google-oss-bot commented May 30, 2023

Uh oh!

google-oss-bot commented May 30, 2023

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

github-actions bot commented May 30, 2023

Unit Test Results

Uh oh!

google-oss-bot commented May 30, 2023

Size Report 1

Affected Products

Test Logs

Uh oh!

cherylEnkidu left a comment

Choose a reason for hiding this comment

Uh oh!

google-oss-bot commented May 30, 2023

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

Uh oh!

Uh oh!

Coverage Report ¹

`firebase-firestore`

Size Report ¹

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`