Skip to content

Commit b6429c8

Browse files
authored
Fix tests by downgrading AppCompat and fixing lint issue (#4132)
1 parent 779acd1 commit b6429c8

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

firebase-appdistribution/firebase-appdistribution.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ dependencies {
6060

6161
compileOnly 'com.google.auto.value:auto-value-annotations:1.6.5'
6262
annotationProcessor 'com.google.auto.value:auto-value:1.6.5'
63-
implementation 'androidx.appcompat:appcompat:1.5.1'
63+
implementation 'androidx.appcompat:appcompat:1.3.1'
6464
implementation "androidx.browser:browser:1.3.0"
6565
implementation "androidx.constraintlayout:constraintlayout:2.1.4"
6666

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FeedbackActivity.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import android.os.Bundle;
1919
import android.text.method.LinkMovementMethod;
2020
import android.view.View;
21+
import android.widget.Button;
2122
import android.widget.EditText;
2223
import android.widget.ImageView;
2324
import android.widget.TextView;
@@ -63,6 +64,8 @@ private void setupView() {
6364
TextView infoTextView = this.findViewById(R.id.infoText);
6465
infoTextView.setText(infoText);
6566
infoTextView.setMovementMethod(LinkMovementMethod.getInstance());
67+
Button submitButton = this.findViewById(R.id.submitButton);
68+
submitButton.setOnClickListener(this::submitFeedback);
6669

6770
Bitmap thumbnail = readThumbnail();
6871
if (thumbnail != null) {

firebase-appdistribution/src/main/res/layout/activity_feedback.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
android:layout_width="wrap_content"
3737
android:layout_height="wrap_content"
3838
android:layout_marginTop="24dp"
39-
android:onClick="submitFeedback"
4039
android:text="Submit"
4140
app:layout_constraintEnd_toEndOf="parent"
4241
app:layout_constraintHorizontal_bias="0.5"

0 commit comments

Comments
 (0)