Skip to content

Fix tests by downgrading AppCompat and fixing lint issue #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Sep 22, 2022

AppCompat was updated in #4104

This requires a compileSdkVersion of 32. Without that the tests fail. Rather than increase compileSdkVersion, which requires our customers to do the same, let's just fix the lint error for now by removing the click handler.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (779acd1) to 76.50% (476e658) by ?.

    39 individual files with coverage change

    FilenameBase (779acd1)Merge (476e658)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?30.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?0.00%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?92.86%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?81.58%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?95.45%?
    InstallActivity.java?2.53%?
    LogWrapper.java?53.33%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?65.63%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.19%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qqLnjSDpms.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022

Size Report 1

Affected Products

  • base

    TypeBase (779acd1)Merge (476e658)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (779acd1)Merge (476e658)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.89 kB? (?)
  • firebase-appdistribution

    TypeBase (779acd1)Merge (476e658)Diff
    aar?153 kB? (?)
    apk (aggressive)?881 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (779acd1)Merge (476e658)Diff
    aar?14.4 kB? (?)
    apk (aggressive)?85.7 kB? (?)
    apk (release)?689 kB? (?)
  • firebase-common

    TypeBase (779acd1)Merge (476e658)Diff
    aar?50.1 kB? (?)
    apk (aggressive)?85.1 kB? (?)
    apk (release)?683 kB? (?)
  • firebase-components

    TypeBase (779acd1)Merge (476e658)Diff
    aar?42.8 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?31.9 kB? (?)
  • firebase-installations

    TypeBase (779acd1)Merge (476e658)Diff
    aar?54.9 kB? (?)
    apk (aggressive)?86.4 kB? (?)
    apk (release)?706 kB? (?)
  • firebase-installations-interop

    TypeBase (779acd1)Merge (476e658)Diff
    aar?8.06 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IP7Hnv4tG9.html

@lfkellogg lfkellogg merged commit b6429c8 into fad/in-app-feedback Sep 22, 2022
@lfkellogg lfkellogg deleted the lk/fix-tests-2 branch September 22, 2022 17:57
@firebase firebase locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants