Skip to content

update appcompat (1.3.0 -> 1.5.1) to fix lint #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

update appcompat (1.3.0 -> 1.5.1) to fix lint #4104

merged 1 commit into from
Sep 15, 2022

Conversation

kaibolay
Copy link
Contributor

UsingOnClickInXml did not work correctly when running with AGP 7.2.2,

@kaibolay
update appcompat (1.3.0 -> 1.5.1) to fix lint (UsingOnClickInXml) whi…
c6d311b 
…ch did not work correctly when running with AGP 7.2.2.
@kaibolay kaibolay requested a review from lfkellogg September 15, 2022 16:07
@kaibolay kaibolay requested a review from vkryachko September 15, 2022 16:07
@kaibolay kaibolay mentioned this pull request Sep 15, 2022
Closed
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (9ff569f) and merge commit (4ad6815).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ucewhlpz8B.html

@kaibolay kaibolay merged commit c841968 into fad/in-app-feedback Sep 15, 2022
@kaibolay kaibolay deleted the kb/appcompat branch September 15, 2022 16:20
kaibolay added a commit that referenced this pull request Sep 15, 2022
@kaibolay
update appcompat (1.3.0 -> 1.5.1) to fix lint (UsingOnClickInXml) whi…
d8c9862 
…ch did not work correctly when running with AGP 7.2.2. (#4104)
@lfkellogg lfkellogg mentioned this pull request Sep 22, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfkellogg lfkellogg lfkellogg approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaibolay @google-oss-bot @lfkellogg