File tree Expand file tree Collapse file tree 4 files changed +12
-7
lines changed
main/java/com/google/firebase/remoteconfig/internal
test/java/com/google/firebase/remoteconfig/internal Expand file tree Collapse file tree 4 files changed +12
-7
lines changed Original file line number Diff line number Diff line change @@ -575,11 +575,14 @@ public static FetchResponse forBackendUpdatesFetched(
575
575
lastFetchETag );
576
576
}
577
577
578
- public static FetchResponse forBackendHasNoUpdates (Date fetchTime ) {
578
+ // Passing in param fetchedConfigs because it contains templateVersion but no other active
579
+ // fields.
580
+ public static FetchResponse forBackendHasNoUpdates (
581
+ Date fetchTime , ConfigContainer fetchedConfigs ) {
579
582
return new FetchResponse (
580
583
fetchTime ,
581
584
Status .BACKEND_HAS_NO_UPDATES ,
582
- /*fetchedConfigs=*/ null ,
585
+ /*fetchedConfigs=*/ fetchedConfigs ,
583
586
/*lastFetchETag=*/ null );
584
587
}
585
588
Original file line number Diff line number Diff line change @@ -216,12 +216,12 @@ FetchResponse fetch(
216
216
} catch (IOException e ) {
217
217
}
218
218
}
219
+ ConfigContainer fetchedConfigs = extractConfigs (fetchResponse , currentTime );
219
220
220
221
if (!backendHasUpdates (fetchResponse )) {
221
- return FetchResponse .forBackendHasNoUpdates (currentTime );
222
+ return FetchResponse .forBackendHasNoUpdates (currentTime , fetchedConfigs );
222
223
}
223
224
224
- ConfigContainer fetchedConfigs = extractConfigs (fetchResponse , currentTime );
225
225
return FetchResponse .forBackendUpdatesFetched (fetchedConfigs , fetchResponseETag );
226
226
}
227
227
Original file line number Diff line number Diff line change @@ -794,7 +794,7 @@ private void setBackendResponseToNoChange(Date date) throws Exception {
794
794
/* customHeaders= */ any (),
795
795
/* firstOpenTime= */ any (),
796
796
/* currentTime= */ any ()))
797
- .thenReturn (FetchResponse .forBackendHasNoUpdates (date ));
797
+ .thenReturn (FetchResponse .forBackendHasNoUpdates (date , firstFetchedContainer ));
798
798
}
799
799
800
800
private void fetchCallToBackendThrowsException (int httpErrorCode ) throws Exception {
Original file line number Diff line number Diff line change @@ -161,13 +161,15 @@ public void fetch_newValues_responseSet() throws Exception {
161
161
}
162
162
163
163
@ Test
164
- public void fetch_noChange_responseNotSet () throws Exception {
164
+ public void fetch_noChange_responseOnlyContainsTemplateVersion () throws Exception {
165
165
setServerResponseTo (noChangeResponseBody , SECOND_ETAG );
166
166
167
167
FetchResponse response = fetch (SECOND_ETAG );
168
168
169
169
assertThat (response .getLastFetchETag ()).isNull ();
170
- assertThat (response .getFetchedConfigs ()).isNull ();
170
+ assertThat (response .getFetchedConfigs ()).isNotNull ();
171
+ assertThat (response .getFetchedConfigs ().getTemplateVersionNumber ()).isNotNull ();
172
+ assertThat (response .getFetchedConfigs ().getConfigs ().length ()).isEqualTo (0 );
171
173
}
172
174
173
175
@ Test
You can’t perform that action at this time.
0 commit comments