Skip to content

Commit ed794ec

Browse files
committed
Revert back to Java 8 compatible changes since perf is not Java 11 compatible yet.
1 parent 5e78c1f commit ed794ec

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfTraceValidatorTest.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,17 +220,25 @@ public void traceValidator_customAttributeEmptyKeyAndValue_marksPerfMetricInvali
220220

221221
@Test
222222
public void traceValidator_customAttributeWithLongKey_marksPerfMetricInvalid() {
223+
224+
StringBuilder longString = new StringBuilder();
225+
for (int i = 0; i <= Constants.MAX_ATTRIBUTE_KEY_LENGTH; i++) {
226+
longString.append("a");
227+
}
223228
TraceMetric.Builder trace =
224-
createValidTraceMetric()
225-
.putCustomAttributes("a".repeat(Constants.MAX_ATTRIBUTE_KEY_LENGTH + 1), "value");
229+
createValidTraceMetric().putCustomAttributes(longString.toString(), "value");
226230
assertThat(new FirebasePerfTraceValidator(trace.build()).isValidPerfMetric()).isFalse();
227231
}
228232

229233
@Test
230234
public void traceValidator_customAttributeWithLongValue_marksPerfMetricInvalid() {
235+
236+
StringBuilder longString = new StringBuilder();
237+
for (int i = 0; i <= Constants.MAX_ATTRIBUTE_VALUE_LENGTH; i++) {
238+
longString.append("a");
239+
}
231240
TraceMetric.Builder trace =
232-
createValidTraceMetric()
233-
.putCustomAttributes("key", "a".repeat(Constants.MAX_ATTRIBUTE_VALUE_LENGTH + 1));
241+
createValidTraceMetric().putCustomAttributes("key", longString.toString());
234242
assertThat(new FirebasePerfTraceValidator(trace.build()).isValidPerfMetric()).isFalse();
235243
}
236244

0 commit comments

Comments
 (0)