Ignore empty message string in FirebaseFunctionsException (#501)

muZk · samtstern · commit f75706500a72 · 2019-06-06T16:00:08.000-07:00
diff --git a/firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctionsException.java b/firebase-functions/src/main/java/com/google/firebase/functions/FirebaseFunctionsException.java
@@ -199,7 +199,7 @@ static Code fromHttpStatus(int status) {
         // The default description needs to be updated for the new code.
         description = code.name();
       }
-      if (error.opt("message") instanceof String) {
+      if (error.opt("message") instanceof String && !error.getString("message").isEmpty()) {
         description = error.getString("message");
       }
       details = error.opt("details");

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ static Code fromHttpStatus(int status) {`
`199`	`199`	`// The default description needs to be updated for the new code.`
`200`	`200`	`description = code.name();`
`201`	`201`	`}`
`202`		`- if (error.opt("message") instanceof String) {`
	`202`	`+ if (error.opt("message") instanceof String && !error.getString("message").isEmpty()) {`
`203`	`203`	`description = error.getString("message");`
`204`	`204`	`}`
`205`	`205`	`details = error.opt("details");`