Ignore empty message string in FirebaseFunctionsException

[muZk]

When throwing new HttpsError('not-found') in a cloud function (ie: without specifying message parameter), error.opt("message") will be just an empty string, so:

• error.opt("message") instanceof String is true
• details will be assigned to "".
• new FirebaseFunctionsException(description, code, details) will be called with this empty string
• it will throws a Detail message must not be empty exception.

With this change, details will be equal to whatever code.name() returns when the cloud function sends an empty string as a message. In the case of HttpsError('not-found'), it will be NOT_FOUND.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[google-oss-bot]

Hi @muZk. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[muZk]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[samtstern]

@muZk this LGTM!

@bklimt any concerns?

[samtstern]

/ok-to-test

[bklimt]

Looks good to me. Thanks for the fix!

I was considering whether it might be better to do error.opt("message", null), but no, I think this PR is better, because an explicit empty string wouldn't work anyway.

Looks like the line might be too long. Make sure to run ./gradlew :firebase-functions:googleJavaFormat to auto format it. I think that's the command, but can't look it up atm.

[muZk]

Looks like the line might be too long. Make sure to run ./gradlew :firebase-functions:googleJavaFormat to auto format it. I think that's the command, but can't look it up atm.

Yes, that's the command! I just ran it without modifications. Maybe it is ok? (93 char long)

[samtstern]

@muZk thanks! Gonna merge this now.