Skip to content

Disable registrar test for FirebaseSegmentation. #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Dec 10, 2019
Merged

Conversation

diwu-arete
Copy link
Contributor

No description provided.

cache and update to Firebase Segmentation backend. CL also contains unit
tests.
(The http client is not implemented yet.)
diwu-arete added 20 commits July 8, 2019 13:46
1. Clean up http client response code.
2. When updateCustomInstallationId is called, on non-retryable server errors, the SDK should clean up the local cache. Instead, for retryable errors, SDK can keep the local cache for retrying update later.
@diwu-arete diwu-arete changed the base branch from master to floc-master December 10, 2019 19:24
@googlebot googlebot added the cla: yes Override cla label Dec 10, 2019
@diwu-arete diwu-arete merged commit cb99bb7 into floc-master Dec 10, 2019
@google-oss-bot
Copy link
Contributor

@diwu-arete: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information 557ea7a link /test api-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (floc-master@5943944). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             floc-master    #1050   +/-   ##
==============================================
  Coverage               ?   57.97%           
  Complexity             ?     6199           
==============================================
  Files                  ?      628           
  Lines                  ?    30955           
  Branches               ?     4262           
==============================================
  Hits                   ?    17945           
  Misses                 ?    11584           
  Partials               ?     1426
Impacted Files Coverage Δ Complexity Δ
.../segmentation/local/CustomInstallationIdCache.java 0% <0%> (ø) 0 <0> (?)
...segmentation/remote/SegmentationServiceClient.java 0% <0%> (ø) 0 <0> (?)
...n/java/com/google/firebase/segmentation/Utils.java 0% <0%> (ø) 0 <0> (?)
...segmentation/SetCustomInstallationIdException.java 0% <0%> (ø) 0 <0> (?)
...ion/local/CustomInstallationIdCacheEntryValue.java 0% <0%> (ø) 0 <0> (?)
...le/firebase/segmentation/FirebaseSegmentation.java 0% <0%> (ø) 0 <0> (?)
...se/segmentation/FirebaseSegmentationRegistrar.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5943944...557ea7a. Read the comment docs.

@firebase firebase locked and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants