[FLoC] Change FLoC instrumental tests to be unit tests. #1058
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // Copyright 2019 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.firebase.segmentation; | ||
|
|
||
| import androidx.annotation.NonNull; | ||
| import com.google.android.gms.tasks.OnCompleteListener; | ||
| import com.google.android.gms.tasks.Task; | ||
| import java.io.IOException; | ||
| import java.util.concurrent.CountDownLatch; | ||
| import java.util.concurrent.ExecutionException; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| /** | ||
| * Helper listener that works around a limitation of the Tasks API where await() cannot be called on | ||
| * the main thread. This listener works around it by running itself on a different thread, thus | ||
| * allowing the main thread to be woken up when the Tasks complete. | ||
| */ | ||
| public class TestOnCompleteListener<TResult> implements OnCompleteListener<TResult> { | ||
| private static final long TIMEOUT_MS = 5000; | ||
| private final CountDownLatch latch = new CountDownLatch(1); | ||
| private Task<TResult> task; | ||
| private volatile TResult result; | ||
| private volatile Exception exception; | ||
| private volatile boolean successful; | ||
|
|
||
| @Override | ||
| public void onComplete(@NonNull Task<TResult> task) { | ||
| this.task = task; | ||
| successful = task.isSuccessful(); | ||
| if (successful) { | ||
| result = task.getResult(); | ||
| } else { | ||
| exception = task.getException(); | ||
| } | ||
| latch.countDown(); | ||
| } | ||
|
|
||
| /** Blocks until the {@link #onComplete} is called. */ | ||
| public TResult await() throws InterruptedException, ExecutionException { | ||
| if (!latch.await(TIMEOUT_MS, TimeUnit.MILLISECONDS)) { | ||
| throw new InterruptedException("timed out waiting for result"); | ||
| } | ||
| if (successful) { | ||
| return result; | ||
| } else { | ||
| if (exception instanceof InterruptedException) { | ||
| throw (InterruptedException) exception; | ||
| } | ||
| if (exception instanceof SetCustomInstallationIdException) { | ||
| throw new ExecutionException(exception); | ||
| } | ||
| if (exception instanceof IOException) { | ||
| throw new ExecutionException(exception); | ||
| } | ||
| throw new IllegalStateException("got an unexpected exception type", exception); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: We can move this into an initialization method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, first, I don't think we can put this entire block into initialization() since it's not always the same in every test case.
If you meant that move TestOnCompleteListener onCompleteListener = new TestOnCompleteListener<>() into initialization, I also think putting here is better since it's a whole logic block with the two lines below. Also, if a test case uses onCompleteListener more than once, then putting it in initialization is also not perfect.