Skip to content

Check for mandatory Firebase Options. #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2020
Merged

Check for mandatory Firebase Options. #1140

merged 4 commits into from
Jan 16, 2020

Conversation

ankitaj224
Copy link
Contributor

No description provided.

@ankitaj224 ankitaj224 requested a review from andirayo January 16, 2020 22:19
@googlebot googlebot added cla: yes Override cla labels Jan 16, 2020
andirayo
andirayo approved these changes Jan 16, 2020
View reviewed changes
...ase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java Outdated
/** Returns the Project Id or Project Number for the Google Cloud Project. */
@Nullable
String getProjectIdentifier() {
return firebaseApp.getOptions().getProjectId() == null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use #isEmpty()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.PTAL

...ase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java Outdated
*/
private void preConditionChecks() {
Preconditions.checkNotNull(getApplicationId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you define the method #getApplicationId?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was defined previously. git only shows the changes - you can see the method:

firebase-android-sdk/firebase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java

Line 143 in cbb626b

String getApplicationId() {

@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #1140 into master will increase coverage by 3.58%.
The diff coverage is 87.5%.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson ? ?
#Encoders_FirebaseEncodersProcessor ? ?
#Encoders_FirebaseEncodersReflective ? ?
#FirebaseAbt ? ?
#FirebaseCommon ? ?
#FirebaseCommon_DataCollectionTests ? ?
#FirebaseCommon_Ktx ? ?
#FirebaseComponents ? ?
#FirebaseConfig ? ?
#FirebaseConfig_Ktx ? ?
#FirebaseCrashlytics ? ?
#FirebaseDatabase ? ?
#FirebaseDatabaseCollection ? ?
#FirebaseDatabase_Ktx ? ?
#FirebaseDatatransport ? ?
#FirebaseDynamicLinks ? ?
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore ? ?
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions ? ?
#FirebaseFunctions_Ktx ? ?
#FirebaseInappmessaging ? ?
#FirebaseInappmessagingDisplay ? ?
#FirebaseInappmessagingDisplay_Ktx ? ?
#FirebaseInappmessaging_Ktx ? ?
#FirebaseInstallations 58.19% <87.5%> (-0.06%) 101 <3> (+2)
#FirebaseStorage ? ?
#FirebaseStorage_Ktx ? ?
#Tools_Errorprone ? ?
#Tools_Lint ? ?
#Transport_TransportBackendCct ? ?
#Transport_TransportRuntime ? ?
Impacted Files Coverage Δ Complexity Δ
.../firebase/installations/FirebaseInstallations.java 92.54% <87.5%> (-1.09%) 41 <3> (+2)
.../inappmessaging/internal/AbtIntegrationHelper.java
...atabase/collection/ImmutableSortedMapIterator.java
...ndroid/datatransport/cct/internal/LogResponse.java
.../main/java/com/google/firebase/firestore/Blob.java
...ng/internal/injection/modules/RateLimitModule.java
...om/google/firebase/firestore/SnapshotMetadata.java
...ytics/internal/settings/SettingsCacheBehavior.java
...ndroid/datatransport/runtime/TransportContext.java
...cs/internal/settings/network/UpdateAppSpiCall.java
... and 666 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4212044...5850071. Read the comment docs.

@ankitaj224 ankitaj224 requested a review from andirayo January 16, 2020 23:25
andirayo
andirayo reviewed Jan 16, 2020
View reviewed changes
...ase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java
@@ -14,6 +14,7 @@

package com.google.firebase.installations;

import android.text.TextUtils;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I did not make you add another factor that could make our SDK fail, haha

@ankitaj224 ankitaj224 merged commit 331ec37 into master Jan 16, 2020
@firebase firebase locked and limited conversation to collaborators Feb 16, 2020
@kaibolay kaibolay deleted the fis_fallback branch September 14, 2022 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andirayo andirayo andirayo approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankitaj224 @andirayo @googlebot @google-oss-bot