Add an ObjectValue builder #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
changed the base branch from
master
to
mrschmidt/rewritefieldvalue
Codecov Report
Continue to review full report at Codecov.
|
wilhuff
reviewed
Jan 22, 2020
| @@ -117,7 +117,7 @@ public ParsedUpdateData parseUpdateData(Map<String, Object> data) { | |||
|
|
|||
| ParseAccumulator accumulator = new ParseAccumulator(UserData.Source.Update); | |||
| ParseContext context = accumulator.rootContext(); | |||
| ObjectValue updateData = ObjectValue.emptyObject(); | |||
| ObjectValue.Builder updateData = ObjectValue.Builder.emptyBuilder(); | |||
There was a problem hiding this comment.
This is pretty verbose. How about ObjectValue.newBuilder()?
There was a problem hiding this comment.
Works for me. I got inspired by the rest of the Protobuf API.
| for (int i = 0; i < fieldTransforms.size(); i++) { | ||
| FieldTransform fieldTransform = fieldTransforms.get(i); | ||
| FieldPath fieldPath = fieldTransform.getFieldPath(); | ||
| objectValue = objectValue.set(fieldPath, transformResults.get(i)); | ||
| builder.set(fieldPath, transformResults.get(i)).build(); |
There was a problem hiding this comment.
Trailing .build() here seems wrong.
| @@ -356,4 +374,12 @@ public void testValueOrdering() { | |||
| .addEqualityGroup(wrapObject(map("foo", "0"))) | |||
| .testCompare(); | |||
| } | |||
|
|
|||
| private ObjectValue setField(ObjectValue empty, String a, FieldValue mod) { | |||
There was a problem hiding this comment.
The caller doesn't necessarily have to pass an empty object, do they? Seems like empty could be objectValue, as it is below.
There was a problem hiding this comment.
Yeah, it should have been objectValue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to pave the way for a mutable ObjectValue that is based on a Value.Builder. It proves that we only need
set()anddelete()(and notequals()andcompareTo()) on the mutable type since most parts of the code still deal with immutable ObjectValues.This is meant for an feature branch until we finish the Proto conversion as ObjectValue.Builder().set() is somewhat inefficient for nested field updates.