Drop FieldValue from tests #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
changed the base branch from
mrschmidt/rewritefieldvalue
to
master
schmidt-sebastian
changed the base branch from
master
to
mrschmidt/rewritefieldvalue
Codecov Report
Continue to review full report at Codecov.
|
wilhuff
approved these changes
Feb 7, 2020
| @@ -31,9 +31,9 @@ | |||
| @Config(manifest = Config.NONE) | |||
| public class ObjectValueBuilderTest { | |||
| private String fooString = "foo"; | |||
| private Value fooValue = valueOf(fooString); | |||
| private Value fooValue = TestUtil.wrap(fooString); | |||
There was a problem hiding this comment.
Static import TestUtil.wrap (to match other usages above).
| } | ||
|
|
||
| @Test | ||
| public void testEncodesNull() { | ||
| FieldValue value = wrap(null); | ||
| Value value = wrap(null); | ||
| com.google.firestore.v1.Value proto = valueBuilder().setNullValueValue(0).build(); |
There was a problem hiding this comment.
Replace fully qualified com.google.firestore.v1.Value declarations in here with just Value?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap()returnsValueand replacesvalueOf()test helperFieldValueTest.testValueEquality(),FieldValueTest.testValueOrdering()andFieldValueTest.testCanonicalIds()to a new ProtoValuesTest files that test the ProtoValues functionality directly (via a small FieldValue-alike helper)This is the last cleanup PR before I want to merge to master. We can discuss if we should proceed with the suggested renames as well.