Skip to content

Changelog for FieldValue change #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

Changelog PRs are the most fun.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #1219 into mrschmidt/rewritefieldvalue will increase coverage by 0.01%.
The diff coverage is n/a.

Flag Coverage Δ Complexity Δ
#FirebaseFirestore 61.93% <ø> (+0.01%) 2226 <ø> (+1) ⬆️
#FirebaseFirestore_Ktx 41.17% <ø> (ø) 0 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
.../com/google/firebase/firestore/UserDataWriter.java 50% <0%> (+1.92%) 16% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0925f...304db8f. Read the comment docs.

@@ -1,4 +1,9 @@
# Unreleased (21.4.0)
# Unreleased
- [changed] Internal changes to the in-memory representation of Firestore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a past-tense sentence. Something like:

Changed the in-memory representation of Firestore documents to reduce memory allocation and improve performance. Users of DocumentSnapshot.getData() and DocumentSnapshot.toObject() will see the biggest improvement.

WDYT?

Copy link
Contributor Author

@schmidt-sebastian schmidt-sebastian Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to:

Changed the in-memory representation of Firestore documents to
reduce memory allocations and improve performance. Calls to 
`DocumentSnapshot.getData()` and `DocumentSnapshot.toObject()` will see
the biggest improvement.

I would think that all our users use these methods, so I changed "users of" to "calls to".

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Feb 7, 2020
@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 304db8f link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Feb 7, 2020
@schmidt-sebastian schmidt-sebastian merged commit 9775f67 into mrschmidt/rewritefieldvalue Feb 7, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/changelog branch February 8, 2020 01:32
@firebase firebase locked and limited conversation to collaborators Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants