-
Notifications
You must be signed in to change notification settings - Fork 625
Changelog for FieldValue change #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for FieldValue change #1219
Conversation
Codecov Report
Continue to review full report at Codecov.
|
firebase-firestore/CHANGELOG.md
Outdated
@@ -1,4 +1,9 @@ | |||
# Unreleased (21.4.0) | |||
# Unreleased | |||
- [changed] Internal changes to the in-memory representation of Firestore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a past-tense sentence. Something like:
Changed the in-memory representation of Firestore documents to reduce memory allocation and improve performance. Users of
DocumentSnapshot.getData()
andDocumentSnapshot.toObject()
will see the biggest improvement.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to:
Changed the in-memory representation of Firestore documents to
reduce memory allocations and improve performance. Calls to
`DocumentSnapshot.getData()` and `DocumentSnapshot.toObject()` will see
the biggest improvement.
I would think that all our users use these methods, so I changed "users of" to "calls to".
@schmidt-sebastian: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog PRs are the most fun.