Skip to content

Remove value package, rename ProtoValues #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

FYI: Copyright dates were adjusted by Android Studio plugin.

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think you can revert the android studio copyright changes. It's just looking at whether or not the file is new without considering that it was moved from the other location.

@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Feb 7, 2020
@schmidt-sebastian
Copy link
Contributor Author

I think you can revert the android studio copyright changes. It's just looking at whether or not the file is new without considering that it was moved from the other location.

Done. I debated keeping the changes since the files are basically completely rewritten.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #1225 into mrschmidt/rewritefieldvalue will decrease coverage by <.01%.
The diff coverage is 72.97%.

Flag Coverage Δ Complexity Δ
#FirebaseFirestore 61.85% <72.97%> (-0.01%) 2224 <5> (ø)
#FirebaseFirestore_Ktx 41.17% <ø> (ø) 0 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...store/model/mutation/ServerTimestampOperation.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...firebase/firestore/model/mutation/SetMutation.java 64% <ø> (ø) 8 <0> (ø) ⬇️
...le/firebase/firestore/model/mutation/Mutation.java 87.5% <ø> (ø) 9 <0> (ø) ⬇️
...rebase/firestore/model/mutation/PatchMutation.java 82.22% <ø> (ø) 16 <0> (ø) ⬇️
...ebase/firestore/model/mutation/DeleteMutation.java 68.42% <ø> (ø) 7 <0> (ø) ⬇️
...se/firestore/model/mutation/TransformMutation.java 81.92% <ø> (ø) 22 <0> (ø) ⬇️
...a/com/google/firebase/firestore/core/UserData.java 49.51% <ø> (ø) 0 <0> (ø) ⬇️
...om/google/firebase/firestore/local/LocalStore.java 95.23% <ø> (ø) 67 <0> (ø) ⬇️
...ebase/firestore/model/mutation/VerifyMutation.java 30.76% <ø> (ø) 2 <0> (ø) ⬇️
.../com/google/firebase/firestore/UserDataWriter.java 49.05% <ø> (ø) 16 <0> (ø) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4864c6a...2309b15. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit fdf249d into mrschmidt/rewritefieldvalue Feb 7, 2020
@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 2309b15 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/renames branch February 8, 2020 01:32
@firebase firebase locked and limited conversation to collaborators Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants