-
Notifications
You must be signed in to change notification settings - Fork 625
Remove value package, rename ProtoValues #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove value package, rename ProtoValues #1225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think you can revert the android studio copyright changes. It's just looking at whether or not the file is new without considering that it was moved from the other location.
Done. I debated keeping the changes since the files are basically completely rewritten. |
@schmidt-sebastian: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
FYI: Copyright dates were adjusted by Android Studio plugin.