Skip to content

Prototype a lint check for fis. #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2020
Merged

Prototype a lint check for fis. #1346

merged 4 commits into from
Mar 13, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Override cla label Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #1346 into master will decrease coverage by 1.58%.
The diff coverage is n/a.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson 95.93% <ø> (ø) 68 <ø> (ø) ⬇️
#Encoders_FirebaseEncodersProcessor 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Encoders_FirebaseEncodersReflective 73.97% <ø> (ø) 20 <ø> (ø) ⬇️
#FirebaseAbt 80.21% <ø> (ø) 47 <ø> (ø) ⬇️
#FirebaseCommon 50.69% <ø> (ø) 64 <ø> (ø) ⬇️
#FirebaseCommon_DataCollectionTests 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseCommon_Ktx 90% <ø> (ø) 1 <ø> (ø) ⬇️
#FirebaseComponents 87.44% <ø> (ø) 145 <ø> (ø) ⬇️
#FirebaseConfig 87.22% <ø> (ø) 307 <ø> (ø) ⬇️
#FirebaseConfig_Ktx 75% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseCrashlytics 2.29% <ø> (ø) 22 <ø> (ø) ⬇️
#FirebaseDatabase 48.34% <ø> (-0.05%) 1806 <ø> (-2)
#FirebaseDatabaseCollection 72.62% <ø> (ø) 169 <ø> (ø) ⬇️
#FirebaseDatabase_Ktx 85.71% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseDatatransport 100% <ø> (ø) 3 <ø> (ø) ⬇️
#FirebaseDynamicLinks 77.35% <ø> (+0.11%) 89 <ø> (ø) ⬇️
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore 61.88% <ø> (+0.03%) 2228 <ø> (ø) ⬇️
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions 5.31% <ø> (ø) 2 <ø> (ø) ⬇️
#FirebaseFunctions_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInappmessaging 68.56% <ø> (+17.04%) 399 <ø> (-129) ⬇️
#FirebaseInappmessagingDisplay ? ?
#FirebaseInappmessagingDisplay_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInappmessaging_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInstallations 58.42% <ø> (ø) 110 <ø> (ø) ⬇️
#FirebaseSegmentation ? ?
#FirebaseStorage ? ?
#FirebaseStorage_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Tools_Errorprone 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Tools_Lint ? ?
#Transport_TransportBackendCct 91.38% <ø> (ø) 96 <ø> (ø) ⬇️
#Transport_TransportRuntime ? ?

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a925e6...bc4aa31. Read the comment docs.

@vkryachko vkryachko mentioned this pull request Mar 12, 2020
Closed
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 12, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (7a925e6)Head (fe97ee7)Diff
firebase-inappmessagingapk (release)?3256454.00? (?)
aar?468226.00? (?)
apk (aggressive)?601521.00? (?)
firebase-common:ktxaar?5965.00? (?)
protolite-well-known-typesapk (release)?561089.00? (?)
aar?1203203.00? (?)
apk (aggressive)?122384.00? (?)
firebase-inappmessaging:ktxaar?5003.00? (?)
firebase-segmentationapk (release)?1667839.00? (?)
aar?35427.00? (?)
apk (aggressive)?1017145.00? (?)
firebase-database:ktxaar?6706.00? (?)
firebase-functions:ktxaar?5844.00? (?)
firebase-storageapk (release)?976604.00? (?)
aar?119257.00? (?)
apk (aggressive)?325635.00? (?)
firebase-commonapk (release)?646638.00? (?)
aar?34517.00? (?)
apk (aggressive)?82949.00? (?)
encoders:firebase-encoders-jsonaar?15334.00? (?)
firebase-firestore:ktxaar?7093.00? (?)
firebase-crashlytics-ndkapk (release)?1930174.00? (?)
aar?598166.00? (?)
apk (aggressive)?1163174.00? (?)
transport:transport-apiaar?6439.00? (?)
transport:transport-backend-cctaar?38343.00? (?)
firebase-inappmessaging-display:ktxaar?21928.00? (?)
firebase-databaseapk (release)?1101570.00? (?)
aar?480458.00? (?)
apk (aggressive)?325603.00? (?)
encoders:firebase-encoders-reflectiveaar?7650.00? (?)
firebase-crashlyticsapk (release)?1347845.00? (?)
aar?376556.00? (?)
apk (aggressive)?580154.00? (?)
transport:transport-runtimeaar?122725.00? (?)
firebase-installationsapk (release)?665330.00? (?)
aar?53594.00? (?)
apk (aggressive)?84609.00? (?)
firebase-config:ktxaar?6162.00? (?)
firebase-dynamic-linksapk (release)?951227.00? (?)
aar?51149.00? (?)
apk (aggressive)?327458.00? (?)
firebase-storage:ktxaar?6143.00? (?)
firebase-installations-interopapk (release)?616109.00? (?)
aar?7509.00? (?)
apk (aggressive)?61699.00? (?)
firebase-componentsapk (release)?25749.00? (?)
aar?34495.00? (?)
apk (aggressive)?10960.00? (?)
firebase-abtapk (release)?746406.00? (?)
aar?35383.00? (?)
apk (aggressive)?85712.00? (?)
firebase-configapk (release)?1143995.00? (?)
aar?214548.00? (?)
apk (aggressive)?395817.00? (?)
firebase-datatransportapk (release)?711399.00? (?)
aar?5041.00? (?)
apk (aggressive)?116357.00? (?)
firebase-dynamic-links:ktxaar?7877.00? (?)
firebase-inappmessaging-displayapk (release)?4776659.00? (?)
aar?165668.00? (?)
apk (aggressive)?1742792.00? (?)
firebase-functionsapk (release)?1178560.00? (?)
aar?25859.00? (?)
apk (aggressive)?393455.00? (?)
firebase-database-collectionapk (release)?912665.00? (?)
aar?34214.00? (?)
apk (aggressive)?313615.00? (?)
firebase-firestoreapk (release)?3140031.00? (?)
aar?1067197.00? (?)
apk (aggressive)?443184.00? (?)
baseapk (release)?8754.00? (?)
apk (aggressive)?10678.00? (?)
Metric Unit: byte

Test Logs

@ankitaj224 ankitaj224 mentioned this pull request Mar 12, 2020
Merged
ankitaj224
ankitaj224 approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@ankitaj224 ankitaj224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if other firebase teams ( eg: fiam ) adds dependency like this:

implementation project(':firebase-installations-interop')
runtimeOnly project(':firebase-installations')

Will the lint check run even then?

@vkryachko
Copy link
Member Author

@ankitaj224 the check will run but it will not find iid among dependencies, hence it will not fail

@vkryachko vkryachko merged commit be3d806 into master Mar 13, 2020
@ankitaj224
Copy link
Contributor

@ankitaj224 the check will run but it will not find iid among dependencies, hence it will not fail

In case of FIAM- that's correct. But if some other teams have iid dependency I can assume it will correctly identify that.

@vkryachko vkryachko deleted the vk.fis_lint_check branch March 13, 2020 19:43
@ahinchman1 ahinchman1 mentioned this pull request Apr 1, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankitaj224 ankitaj224 ankitaj224 approved these changes

@andirayo andirayo Awaiting requested review from andirayo

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @ankitaj224 @googlebot