Skip to content

Nudge customers to update if on an old Firebase Analytics #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2020
Merged

Nudge customers to update if on an old Firebase Analytics #1349

merged 2 commits into from
Mar 18, 2020

Conversation

mrichards
Copy link
Contributor

We can infer the customer is on an outdated version of FA
if we cannot attach a listener with the "clx" origin. If
that is the case, use the old "crash" origin and write a
logcat warning with a nudge to upgrade.

@mrichards
Nudge customers to update if on an old Firebase Analytics
83a8bbc 
We can infer the customer is on an outdated version of FA
if we cannot attach a listener with the "clx" origin. If
that is the case, use the old "crash" origin and write a
logcat warning with a nudge to upgrade.
@googlebot googlebot added the cla: yes Override cla label Mar 13, 2020
mrichards
mrichards commented Mar 13, 2020
View reviewed changes
...main/java/com/google/firebase/crashlytics/internal/analytics/AnalyticsConnectorReceiver.java Outdated
if (analyticsConnectorHandle != null) {
Logger.getLogger()
.w(
"Outdated version of Firebase Analytics detected. For improved "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to coordinate with the Analytics team on the specific wording, which is likely to change. I created the PR to get feedback on the general approach; don't worry about the warning message just yet.

@codecov
Copy link

codecov bot commented Mar 13, 2020 •
edited
Loading

Codecov Report

Merging #1349 into master will decrease coverage by 50.42%.
The diff coverage is 0%.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson ? ?
#Encoders_FirebaseEncodersProcessor ? ?
#Encoders_FirebaseEncodersReflective ? ?
#FirebaseAbt ? ?
#FirebaseCommon ? ?
#FirebaseCommon_DataCollectionTests ? ?
#FirebaseCommon_Ktx ? ?
#FirebaseComponents ? ?
#FirebaseConfig ? ?
#FirebaseConfig_Ktx ? ?
#FirebaseCrashlytics 2.28% <0%> (-0.01%) 22 <0> (ø)
#FirebaseDatabase ? ?
#FirebaseDatabaseCollection ? ?
#FirebaseDatabase_Ktx ? ?
#FirebaseDatatransport ? ?
#FirebaseDynamicLinks ? ?
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore ? ?
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions ? ?
#FirebaseFunctions_Ktx ? ?
#FirebaseInappmessaging ? ?
#FirebaseInappmessagingDisplay ? ?
#FirebaseInappmessagingDisplay_Ktx ? ?
#FirebaseInappmessaging_Ktx ? ?
#FirebaseInstallations ? ?
#FirebaseSegmentation ? ?
#FirebaseStorage ? ?
#FirebaseStorage_Ktx ? ?
#Tools_Errorprone ? ?
#Tools_Lint ? ?
#Transport_TransportBackendCct ? ?
#Transport_TransportRuntime ? ?

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a925e6...604916a. Read the comment docs.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 13, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (be3d806)Head (604916a)Diff
firebase-inappmessagingapk (release)?3256454.00? (?)
aar?468226.00? (?)
apk (aggressive)?601529.00? (?)
firebase-common:ktxaar?5965.00? (?)
protolite-well-known-typesapk (release)?561089.00? (?)
aar?1203203.00? (?)
apk (aggressive)?122367.00? (?)
firebase-inappmessaging:ktxaar?5003.00? (?)
firebase-segmentationapk (release)?1667839.00? (?)
aar?35427.00? (?)
apk (aggressive)?1017134.00? (?)
firebase-database:ktxaar?6706.00? (?)
firebase-functions:ktxaar?5844.00? (?)
firebase-storageapk (release)?976604.00? (?)
aar?119257.00? (?)
apk (aggressive)?325641.00? (?)
firebase-commonapk (release)?646638.00? (?)
aar?34517.00? (?)
apk (aggressive)?82954.00? (?)
encoders:firebase-encoders-jsonaar?15334.00? (?)
firebase-firestore:ktxaar?7093.00? (?)
firebase-crashlytics-ndkapk (release)?1930380.00? (?)
aar?598166.00? (?)
apk (aggressive)?1163237.00? (?)
transport:transport-apiaar?6439.00? (?)
transport:transport-backend-cctaar?38343.00? (?)
firebase-inappmessaging-display:ktxaar?21928.00? (?)
firebase-databaseapk (release)?1101570.00? (?)
aar?480458.00? (?)
apk (aggressive)?325613.00? (?)
encoders:firebase-encoders-reflectiveaar?7650.00? (?)
firebase-crashlyticsapk (release)?1347768.00? (?)
aar?376727.00? (?)
apk (aggressive)?580207.00? (?)
transport:transport-runtimeaar?122725.00? (?)
firebase-installationsapk (release)?665330.00? (?)
aar?53597.00? (?)
apk (aggressive)?84614.00? (?)
firebase-config:ktxaar?6162.00? (?)
firebase-dynamic-linksapk (release)?951227.00? (?)
aar?51149.00? (?)
apk (aggressive)?327448.00? (?)
firebase-storage:ktxaar?6143.00? (?)
firebase-installations-interopapk (release)?616109.00? (?)
aar?7509.00? (?)
apk (aggressive)?61720.00? (?)
firebase-componentsapk (release)?25749.00? (?)
aar?34495.00? (?)
apk (aggressive)?10964.00? (?)
firebase-abtapk (release)?746406.00? (?)
aar?35383.00? (?)
apk (aggressive)?85721.00? (?)
firebase-configapk (release)?1143995.00? (?)
aar?214548.00? (?)
apk (aggressive)?395836.00? (?)
firebase-datatransportapk (release)?711399.00? (?)
aar?5041.00? (?)
apk (aggressive)?116361.00? (?)
firebase-dynamic-links:ktxaar?7877.00? (?)
firebase-inappmessaging-displayapk (release)?4776659.00? (?)
aar?165668.00? (?)
apk (aggressive)?1742789.00? (?)
firebase-functionsapk (release)?1178560.00? (?)
aar?25859.00? (?)
apk (aggressive)?393476.00? (?)
firebase-database-collectionapk (release)?912665.00? (?)
aar?34214.00? (?)
apk (aggressive)?313626.00? (?)
firebase-firestoreapk (release)?3140031.00? (?)
aar?1067197.00? (?)
apk (aggressive)?443189.00? (?)
baseapk (release)?8754.00? (?)
apk (aggressive)?10665.00? (?)
Metric Unit: byte

Test Logs

@mrwillis21
Copy link
Contributor

A couple small notes. Overall though I'm happy with the approach.

@mrichards mrichards merged commit 84ab316 into master Mar 18, 2020
@firebase firebase locked and limited conversation to collaborators Apr 18, 2020
@mrichards mrichards deleted the crashlytics-FA-warn branch March 22, 2022 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrwillis21 mrwillis21 mrwillis21 approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrichards @google-oss-bot @mrwillis21 @googlebot