Skip to content

Make repository usable on JDK11. #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2020
Merged

Make repository usable on JDK11. #1370

merged 2 commits into from
Mar 19, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Override cla label Mar 19, 2020
@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #1370 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson 95.93% <ø> (ø) 68 <ø> (ø) ⬇️
#Encoders_FirebaseEncodersProcessor 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Encoders_FirebaseEncodersReflective 73.97% <ø> (ø) 20 <ø> (ø) ⬇️
#FirebaseAbt 80.21% <ø> (ø) 47 <ø> (ø) ⬇️
#FirebaseCommon 50.69% <ø> (ø) 64 <ø> (ø) ⬇️
#FirebaseCommon_DataCollectionTests 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseCommon_Ktx 90% <ø> (ø) 1 <ø> (ø) ⬇️
#FirebaseComponents 87.44% <ø> (ø) 145 <ø> (ø) ⬇️
#FirebaseConfig 87.22% <ø> (ø) 307 <ø> (ø) ⬇️
#FirebaseConfig_Ktx 75% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseCrashlytics 2.48% <ø> (ø) 23 <ø> (ø) ⬇️
#FirebaseDatabase 48.34% <ø> (-0.02%) 1807 <ø> (+1)
#FirebaseDatabaseCollection 72.62% <ø> (ø) 169 <ø> (ø) ⬇️
#FirebaseDatabase_Ktx 85.71% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseDatatransport 100% <ø> (ø) 3 <ø> (ø) ⬇️
#FirebaseDynamicLinks 77.24% <ø> (ø) 89 <ø> (ø) ⬇️
#FirebaseDynamicLinks_Ktx 75.67% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseFirestore 61.85% <ø> (ø) 2228 <ø> (ø) ⬇️
#FirebaseFirestore_Ktx 41.17% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseFunctions 5.31% <ø> (ø) 2 <ø> (ø) ⬇️
#FirebaseFunctions_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInappmessaging 51.52% <ø> (ø) 528 <ø> (ø) ⬇️
#FirebaseInappmessagingDisplay 34.52% <ø> (ø) 129 <ø> (ø) ⬇️
#FirebaseInappmessagingDisplay_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInappmessaging_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInstallations 59.01% <ø> (ø) 112 <ø> (ø) ⬇️
#FirebaseSegmentation 52.63% <ø> (ø) 29 <ø> (ø) ⬇️
#FirebaseStorage 76.97% <ø> (-0.09%) 520 <ø> (-2)
#FirebaseStorage_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Tools_Errorprone 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Tools_Lint 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Transport_TransportBackendCct 91.38% <ø> (ø) 96 <ø> (ø) ⬇️
#Transport_TransportRuntime 75.53% <ø> (ø) 191 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a558c1e...72d45da. Read the comment docs.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 19, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (a558c1e)Head (72d45da)Diff
firebase-inappmessagingapk (release)?3256653.00? (?)
aar?467661.00? (?)
apk (aggressive)?601334.00? (?)
firebase-common:ktxaar?5965.00? (?)
protolite-well-known-typesapk (release)?561089.00? (?)
aar?1203203.00? (?)
apk (aggressive)?122384.00? (?)
firebase-inappmessaging:ktxaar?5003.00? (?)
firebase-segmentationapk (release)?1667839.00? (?)
aar?35427.00? (?)
apk (aggressive)?1017151.00? (?)
firebase-database:ktxaar?6706.00? (?)
firebase-functions:ktxaar?5844.00? (?)
firebase-storageapk (release)?976604.00? (?)
aar?119257.00? (?)
apk (aggressive)?325641.00? (?)
firebase-commonapk (release)?646638.00? (?)
aar?34517.00? (?)
apk (aggressive)?82956.00? (?)
encoders:firebase-encoders-jsonaar?15334.00? (?)
firebase-firestore:ktxaar?7093.00? (?)
firebase-crashlytics-ndkapk (release)?1931147.00? (?)
aar?598746.00? (?)
apk (aggressive)?1166954.00? (?)
transport:transport-apiaar?6439.00? (?)
transport:transport-backend-cctaar?38343.00? (?)
firebase-inappmessaging-display:ktxaar?22190.00? (?)
firebase-databaseapk (release)?1101570.00? (?)
aar?480458.00? (?)
apk (aggressive)?325592.00? (?)
encoders:firebase-encoders-reflectiveaar?7650.00? (?)
firebase-crashlyticsapk (release)?1348718.00? (?)
aar?378433.00? (?)
apk (aggressive)?580712.00? (?)
transport:transport-runtimeaar?122725.00? (?)
firebase-installationsapk (release)?665523.00? (?)
aar?55059.00? (?)
apk (aggressive)?84597.00? (?)
firebase-config:ktxaar?6162.00? (?)
firebase-dynamic-linksapk (release)?951227.00? (?)
aar?51149.00? (?)
apk (aggressive)?327459.00? (?)
firebase-storage:ktxaar?6143.00? (?)
firebase-installations-interopapk (release)?616109.00? (?)
aar?7509.00? (?)
apk (aggressive)?61714.00? (?)
firebase-componentsapk (release)?25749.00? (?)
aar?34495.00? (?)
apk (aggressive)?10959.00? (?)
firebase-abtapk (release)?746406.00? (?)
aar?35383.00? (?)
apk (aggressive)?85716.00? (?)
firebase-configapk (release)?1143995.00? (?)
aar?214548.00? (?)
apk (aggressive)?395817.00? (?)
firebase-datatransportapk (release)?711399.00? (?)
aar?5041.00? (?)
apk (aggressive)?116357.00? (?)
firebase-dynamic-links:ktxaar?7877.00? (?)
firebase-inappmessaging-displayapk (release)?4520174.00? (?)
aar?165930.00? (?)
apk (aggressive)?1603058.00? (?)
firebase-functionsapk (release)?1178560.00? (?)
aar?25859.00? (?)
apk (aggressive)?393465.00? (?)
firebase-database-collectionapk (release)?912665.00? (?)
aar?34214.00? (?)
apk (aggressive)?313605.00? (?)
firebase-firestoreapk (release)?3140031.00? (?)
aar?1067197.00? (?)
apk (aggressive)?443174.00? (?)
baseapk (release)?8754.00? (?)
apk (aggressive)?10661.00? (?)
Metric Unit: byte

Test Logs

@vkryachko
Copy link
Member Author

/test device-check-changed

yifanyang
yifanyang approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@yifanyang yifanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the JaCoCo part!

@VinayGuthal VinayGuthal self-requested a review March 19, 2020 18:23
@vkryachko vkryachko merged commit a94d79a into master Mar 19, 2020
@vkryachko vkryachko deleted the vk.java11 branch March 20, 2020 23:25
@firebase firebase locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

@yifanyang yifanyang yifanyang approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vkryachko @google-oss-bot @VinayGuthal @yifanyang @googlebot