Skip to content

Fix apk size upload in post-submit runs. #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

yifanyang
Copy link
Contributor

No description provided.

@yifanyang yifanyang requested a review from vkryachko March 24, 2020 18:28
@googlebot googlebot added the cla: yes Override cla label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #1386 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson 95.93% <ø> (ø) 68 <ø> (ø) ⬇️
#Encoders_FirebaseEncodersProcessor 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Encoders_FirebaseEncodersReflective 73.97% <ø> (ø) 20 <ø> (ø) ⬇️
#FirebaseAbt 80.21% <ø> (ø) 47 <ø> (ø) ⬇️
#FirebaseCommon 50.69% <ø> (ø) 64 <ø> (ø) ⬇️
#FirebaseCommon_DataCollectionTests 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseCommon_Ktx 90% <ø> (ø) 1 <ø> (ø) ⬇️
#FirebaseComponents 87.44% <ø> (ø) 145 <ø> (ø) ⬇️
#FirebaseConfig 87.22% <ø> (ø) 307 <ø> (ø) ⬇️
#FirebaseConfig_Ktx 75% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseCrashlytics 2.43% <ø> (ø) 22 <ø> (ø) ⬇️
#FirebaseDatabase 48.36% <ø> (+0.01%) 1808 <ø> (+2) ⬆️
#FirebaseDatabaseCollection 72.62% <ø> (ø) 169 <ø> (ø) ⬇️
#FirebaseDatabase_Ktx 85.71% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseDatatransport 100% <ø> (ø) 3 <ø> (ø) ⬇️
#FirebaseDynamicLinks 77.24% <ø> (ø) 89 <ø> (ø) ⬇️
#FirebaseDynamicLinks_Ktx 75.67% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseFirestore 61.85% <ø> (-0.01%) 2222 <ø> (-7)
#FirebaseFirestore_Ktx 41.17% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseFunctions 5.31% <ø> (ø) 2 <ø> (ø) ⬇️
#FirebaseFunctions_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInappmessaging 51.52% <ø> (ø) 528 <ø> (ø) ⬇️
#FirebaseInappmessagingDisplay 34.52% <ø> (ø) 129 <ø> (ø) ⬇️
#FirebaseInappmessagingDisplay_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInappmessaging_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseInstallations 59.01% <ø> (ø) 112 <ø> (ø) ⬇️
#FirebaseSegmentation 52.63% <ø> (ø) 29 <ø> (ø) ⬇️
#FirebaseStorage 77.06% <ø> (ø) 522 <ø> (ø) ⬇️
#FirebaseStorage_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Tools_Errorprone 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Tools_Lint 100% <ø> (ø) 0 <ø> (ø) ⬇️
#Transport_TransportBackendCct 91.38% <ø> (ø) 96 <ø> (ø) ⬇️
#Transport_TransportRuntime 75.53% <ø> (ø) 191 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5146f...6cdd156. Read the comment docs.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 24, 2020

Binary Size Report

Affected SDKs

SDKTypeBase (5db2238)Head (6cdd156)Diff
firebase-inappmessagingapk (release)?3256653.00? (?)
aar?467661.00? (?)
apk (aggressive)?601337.00? (?)
firebase-common:ktxaar?5965.00? (?)
protolite-well-known-typesapk (release)?561089.00? (?)
aar?1203203.00? (?)
apk (aggressive)?122384.00? (?)
firebase-inappmessaging:ktxaar?5003.00? (?)
firebase-segmentationapk (release)?1667839.00? (?)
aar?35427.00? (?)
apk (aggressive)?1017151.00? (?)
firebase-database:ktxaar?6706.00? (?)
firebase-functions:ktxaar?5844.00? (?)
firebase-storageapk (release)?976604.00? (?)
aar?119257.00? (?)
apk (aggressive)?325624.00? (?)
firebase-commonapk (release)?646638.00? (?)
aar?34517.00? (?)
apk (aggressive)?82939.00? (?)
encoders:firebase-encoders-jsonaar?15334.00? (?)
firebase-firestore:ktxaar?7093.00? (?)
firebase-crashlytics-ndkapk (release)?1935918.00? (?)
aar?598746.00? (?)
apk (aggressive)?1170083.00? (?)
transport:transport-apiaar?6439.00? (?)
transport:transport-backend-cctaar?38343.00? (?)
firebase-inappmessaging-display:ktxaar?22190.00? (?)
firebase-databaseapk (release)?1101570.00? (?)
aar?480458.00? (?)
apk (aggressive)?325602.00? (?)
encoders:firebase-encoders-reflectiveaar?7650.00? (?)
firebase-crashlyticsapk (release)?1352970.00? (?)
aar?397599.00? (?)
apk (aggressive)?583403.00? (?)
transport:transport-runtimeaar?122725.00? (?)
firebase-installationsapk (release)?665523.00? (?)
aar?55056.00? (?)
apk (aggressive)?84602.00? (?)
firebase-config:ktxaar?6162.00? (?)
firebase-dynamic-linksapk (release)?951227.00? (?)
aar?51149.00? (?)
apk (aggressive)?327465.00? (?)
firebase-storage:ktxaar?6143.00? (?)
firebase-installations-interopapk (release)?616109.00? (?)
aar?7509.00? (?)
apk (aggressive)?61714.00? (?)
firebase-componentsapk (release)?25749.00? (?)
aar?34495.00? (?)
apk (aggressive)?10960.00? (?)
firebase-abtapk (release)?746406.00? (?)
aar?35383.00? (?)
apk (aggressive)?85717.00? (?)
firebase-configapk (release)?1143995.00? (?)
aar?214548.00? (?)
apk (aggressive)?395832.00? (?)
firebase-datatransportapk (release)?711399.00? (?)
aar?5041.00? (?)
apk (aggressive)?116357.00? (?)
firebase-dynamic-links:ktxaar?7877.00? (?)
firebase-inappmessaging-displayapk (release)?4520174.00? (?)
aar?165930.00? (?)
apk (aggressive)?1603058.00? (?)
firebase-functionsapk (release)?1178560.00? (?)
aar?25859.00? (?)
apk (aggressive)?393465.00? (?)
firebase-database-collectionapk (release)?912665.00? (?)
aar?34214.00? (?)
apk (aggressive)?313605.00? (?)
firebase-firestoreapk (release)?3139586.00? (?)
aar?1067163.00? (?)
apk (aggressive)?443174.00? (?)
baseapk (release)?8754.00? (?)
apk (aggressive)?10661.00? (?)
Metric Unit: byte

Test Logs

@yifanyang yifanyang merged commit 243810b into master Mar 25, 2020
@yifanyang yifanyang deleted the yifany/fix-postsubmit branch March 25, 2020 16:45
@firebase firebase locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants