Clean up error handling for report persistence #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure data written to disk is cleaned up properly when read/write/serialization errors occur.
Codecov Report
Continue to review full report at Codecov.
|
mrichards
reviewed
Mar 24, 2020
| @@ -46,7 +46,13 @@ public CrashlyticsUncaughtExceptionHandler( | |||
| public void uncaughtException(Thread thread, Throwable ex) { | |||
| isHandlingException.set(true); | |||
| try { | |||
| crashListener.onUncaughtException(settingsDataProvider, thread, ex); | |||
| if (thread == null) { | |||
| Logger.getLogger().d("Could not handle uncaught exception; null thread"); | |||
There was a problem hiding this comment.
What do you think about making some of this output logged as errors, since they are basically logging failed asserts?
There was a problem hiding this comment.
I think in this particular case that makes sense.
Binary Size ReportAffected SDKs
Test Logs |
mrichards
reviewed
Mar 24, 2020
| // called on app start, but keep the current session when called at crash time. Currently | ||
| // this only works when called at app start. | ||
| List<File> sessionDirectories = capAndGetOpenSessions(currentSessionId); | ||
| /** |
There was a problem hiding this comment.
This is a lot cleaner! 😍
mrichards
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Functionally this all looks great. I'd like to see all the debug logging for error conditions use the ERROR log level (or WARN, where appropriate) instead of debug. I'm going to approve the PR as-is so you don't need to wait to merge once those trivial changes are made.
Nice job!
|
/test device-check-changed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure data written to disk is cleaned up properly when
read/write/serialization errors occur.