Skip to content

Revert "Better POJO Support for Document Fields" #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Nov 27, 2018

This reverts commit ddda926.

This makes master shippable again while we wait for API change approvals.

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNLGTM

@wilhuff
Copy link
Contributor Author

wilhuff commented Nov 27, 2018

/retest

@wilhuff
Copy link
Contributor Author

wilhuff commented Nov 27, 2018

/test connected-check

@vkryachko
Copy link
Member

/retest

@wilhuff
Copy link
Contributor Author

wilhuff commented Nov 27, 2018

/test connected-check

1 similar comment
@wilhuff
Copy link
Contributor Author

wilhuff commented Nov 27, 2018

/test connected-check

@mikelehen mikelehen assigned wilhuff and unassigned mikelehen Nov 28, 2018
@wilhuff wilhuff merged commit 6c2e9a5 into master Nov 28, 2018
@wilhuff wilhuff deleted the wilhuff/shippable branch January 7, 2019 22:22
wilhuff added a commit that referenced this pull request Jan 11, 2019
wilhuff added a commit that referenced this pull request Jan 12, 2019
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants