Update spec tests from changes in the firebase-js-sdk respository #1401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
|
Binary Size ReportAffected SDKs
Test Logs |
wilhuff
approved these changes
Mar 30, 2020
| } | ||
| } | ||
| }, | ||
| "clientIndex": 0 | ||
| "clientIndex": 1 |
There was a problem hiding this comment.
It looks like the generator isn't generating a stable order among client indexes?
There was a problem hiding this comment.
I'll look into this and reply back. There must have been a change between now and November 2019 (4 months ago) that affected this as the spec tests have not been regenerated since then.
There was a problem hiding this comment.
Update: The culprit is firebase/firebase-js-sdk#2693, discovered by performing a bisection. I'm continuing to investigate.
There was a problem hiding this comment.
It looks like the change in the spec test is expected; however, in the culprit PR the spec tests for Android (and probably iOS) were not updated accordingly. I will create a separate PR to bring the spec tests up-to-date from the PR so that this PR can encompass only a single update to the spec tests.
There was a problem hiding this comment.
I've created a PR, firebase/firebase-js-sdk#2843, to produce stable JSON from generate_spec_json.js. I will hold off merging this PR until that PR is resolved so that a commit with a noisy diff in the spec tests can be limited to one commit.
There was a problem hiding this comment.
Update: commit 19ab883 was added to this PR with the stable JSON.
The PR firebase/firebase-js-sdk#2843 caused stable JSON to be generated.
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
|
Binary Size ReportAffected SDKs
Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change picks up changes to the spec tests, especially firebase/firebase-js-sdk#2790, which renamed the "limboDocs" key in the JSON objects to "activeLimboDocs".