Remove impressions for Campaigns delivered by backend service #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakhar1989
reviewed
Mar 30, 2020
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ImpressionStorageClient.java
Outdated
Show resolved
Hide resolved
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ImpressionStorageClient.java
Show resolved
Hide resolved
prakhar1989
reviewed
Mar 30, 2020
...essaging/src/main/java/com/google/firebase/inappmessaging/internal/DisplayCallbacksImpl.java
Outdated
Show resolved
Hide resolved
Binary Size ReportAffected SDKs
Test Logs |
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
|
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ImpressionStorageClient.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/com/google/firebase/inappmessaging/internal/InAppMessageStreamManager.java
Outdated
Show resolved
Hide resolved
JasonAHeron
changed the title
JasonAHeron
force-pushed
the
ugh_ugh_ugh
branch
from
b6d2b81 to
ea958eb
Compare
JasonAHeron
force-pushed
the
ugh_ugh_ugh
branch
5 times, most recently
from
64fd9a4 to
14e7225
Compare
...src/test/java/com/google/firebase/inappmessaging/internal/InAppMessageStreamManagerTest.java
Show resolved
Hide resolved
JasonAHeron
force-pushed
the
ugh_ugh_ugh
branch
3 times, most recently
from
a39140d to
e636c74
Compare
prakhar1989
requested changes
Mar 31, 2020
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ImpressionStorageClient.java
Outdated
Show resolved
Hide resolved
...aging/src/main/java/com/google/firebase/inappmessaging/internal/ImpressionStorageClient.java
Show resolved
Hide resolved
...ing/src/main/java/com/google/firebase/inappmessaging/internal/InAppMessageStreamManager.java
Show resolved
Hide resolved
prakhar1989
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.