Skip to content

Sending api key as a request header and not in the request url #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 31, 2020

Conversation

ankitaj224
Copy link
Contributor

No description provided.

@ankitaj224 ankitaj224 requested a review from andirayo March 31, 2020 00:29
@googlebot googlebot added the cla: yes Override cla label Mar 31, 2020
@google-oss-bot
Copy link
Contributor

@ankitaj224: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 8c9602e link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@andirayo andirayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

SDKTypeBase (21f6adf)Head (8c9602e)Diff
Metric Unit: percentage

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2020

Binary Size Report

Affected SDKs

SDKTypeBase (21f6adf)Head (8c9602e)Diff
firebase-inappmessagingapk (release)3256643.003256336.00-307.00 (-0.01%)
apk (aggressive)601333.00601294.00-39.00 (-0.01%)
protolite-well-known-typesapk (aggressive)122384.00122382.00-2.00 (-0.00%)
firebase-segmentationapk (aggressive)1017151.001017134.00-17.00 (-0.00%)
firebase-storageapk (aggressive)325641.00325638.00-3.00 (-0.00%)
firebase-commonapk (aggressive)82956.0082943.00-13.00 (-0.02%)
firebase-crashlytics-ndkapk (aggressive)1170706.001170710.00+4.00 (+0.00%)
firebase-databaseapk (aggressive)325607.00325596.00-11.00 (-0.00%)
firebase-crashlyticsapk (aggressive)583996.00584010.00+14.00 (+0.00%)
firebase-installationsapk (release)665523.00665549.00+26.00 (+0.00%)
aar55053.0055081.00+28.00 (+0.05%)
firebase-dynamic-linksapk (aggressive)327444.00327469.00+25.00 (+0.01%)
firebase-installations-interopapk (aggressive)61716.0061720.00+4.00 (+0.01%)
firebase-componentsapk (aggressive)10960.0010964.00+4.00 (+0.04%)
firebase-abtapk (aggressive)85702.0085706.00+4.00 (+0.00%)
firebase-configapk (aggressive)395817.00395821.00+4.00 (+0.00%)
firebase-datatransportapk (aggressive)116364.00116361.00-3.00 (-0.00%)
firebase-inappmessaging-displayapk (release)4520175.004520370.00+195.00 (+0.00%)
apk (aggressive)1603057.001603006.00-51.00 (-0.00%)
firebase-functionsapk (aggressive)393472.00393476.00+4.00 (+0.00%)
firebase-database-collectionapk (aggressive)313622.00313626.00+4.00 (+0.00%)
firebase-firestoreapk (aggressive)443189.00443178.00-11.00 (-0.00%)
baseapk (aggressive)10676.0010680.00+4.00 (+0.04%)
Metric Unit: byte

Test Logs

@ankitaj224 ankitaj224 merged commit ad62fcc into master Mar 31, 2020
@firebase firebase locked and limited conversation to collaborators May 1, 2020
@kaibolay kaibolay deleted the apikey branch September 14, 2022 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants