Skip to content

Pre-gzip the crashlytics payloads before sending them up #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2020
Merged

Pre-gzip the crashlytics payloads before sending them up #1404

merged 4 commits into from
Apr 1, 2020

Conversation

jakeouellette
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Mar 31, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2020 •
edited
Loading

Coverage Report

Affected SDKs

SDKTypeBase (59e9c3a)Head (746e389)Diff
Metric Unit: percentage

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (59e9c3a)Head (746e389)Diff
firebase-segmentationapk (aggressive)1017130.001017134.00+4.00 (+0.00%)
firebase-storageapk (aggressive)325641.00325624.00-17.00 (-0.01%)
firebase-commonapk (aggressive)82949.0082939.00-10.00 (-0.01%)
firebase-crashlytics-ndkapk (release)1937145.001937310.00+165.00 (+0.01%)
apk (aggressive)1170900.001171166.00+266.00 (+0.02%)
firebase-databaseapk (aggressive)325607.00325606.00-1.00 (-0.00%)
firebase-crashlyticsapk (release)1354111.001354534.00+423.00 (+0.03%)
aar400620.00401552.00+932.00 (+0.23%)
apk (aggressive)584196.00584210.00+14.00 (+0.00%)
firebase-installationsaar55081.0055080.00-1.00 (-0.00%)
apk (aggressive)84583.0084597.00+14.00 (+0.02%)
firebase-dynamic-linksapk (aggressive)327459.00327462.00+3.00 (+0.00%)
firebase-installations-interopapk (aggressive)61714.0061718.00+4.00 (+0.01%)
firebase-componentsapk (aggressive)10959.0010949.00-10.00 (-0.09%)
firebase-abtapk (aggressive)85702.0085723.00+21.00 (+0.02%)
firebase-configapk (aggressive)395832.00395835.00+3.00 (+0.00%)
firebase-datatransportapk (aggressive)116364.00116362.00-2.00 (-0.00%)
firebase-inappmessaging-displayapk (aggressive)1603008.001603006.00-2.00 (-0.00%)
firebase-functionsapk (aggressive)393470.00393469.00-1.00 (-0.00%)
firebase-firestoreapk (aggressive)443189.00443188.00-1.00 (-0.00%)
baseapk (aggressive)10661.0010665.00+4.00 (+0.04%)
Metric Unit: byte

Test Logs

@jakeouellette jakeouellette force-pushed the pregzip-crashlytics-payloads branch from 7009c35 to b01fe64 Compare March 31, 2020 21:21
@jakeouellette jakeouellette force-pushed the pregzip-crashlytics-payloads branch from b01fe64 to 63e7b54 Compare March 31, 2020 21:23
@jakeouellette
Copy link
Contributor Author

/retest

@jakeouellette jakeouellette merged commit 7d0a217 into master Apr 1, 2020
@mrwillis21 mrwillis21 deleted the pregzip-crashlytics-payloads branch April 1, 2020 00:22
@jakeouellette
Copy link
Contributor Author

/retest

@firebase firebase locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrwillis21 mrwillis21 mrwillis21 approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakeouellette @google-oss-bot @mrwillis21 @googlebot