Skip to content

Make ServerValue.increment() public #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

As per API proposal: go/servervalue-increment-api

As per API proposal: go/servervalue-increment-api
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

SDKTypeBase (068ca6f)Head (c304e03)Diff
firebase-databaseChildChangeAccumulator.java0.840.97+0.13 (+15.38%)
BooleanNode.java0.921.00+0.08 (+8.33%)
DoubleNode.java1.000.89-0.11 (-11.11%)
Metric Unit: percentage

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2020

Binary Size Report

Affected SDKs

SDKTypeBase (068ca6f)Head (c304e03)Diff
firebase-inappmessagingapk (aggressive)852132.00852136.00+4.00 (+0.00%)
protolite-well-known-typesapk (aggressive)122384.00122371.00-13.00 (-0.01%)
firebase-segmentationapk (aggressive)1017149.001017138.00-11.00 (-0.00%)
firebase-storageapk (aggressive)325634.00325645.00+11.00 (+0.00%)
firebase-commonapk (aggressive)82949.0082960.00+11.00 (+0.01%)
firebase-crashlytics-ndkapk (aggressive)1170698.001170702.00+4.00 (+0.00%)
firebase-databaseapk (release)1101864.001101861.00-3.00 (-0.00%)
aar481591.00481593.00+2.00 (+0.00%)
apk (aggressive)325592.00325611.00+19.00 (+0.01%)
firebase-crashlyticsapk (aggressive)583632.00583646.00+14.00 (+0.00%)
firebase-installationsapk (aggressive)84598.0084587.00-11.00 (-0.01%)
firebase-dynamic-linksapk (aggressive)327448.00327469.00+21.00 (+0.01%)
firebase-installations-interopapk (aggressive)61714.0061718.00+4.00 (+0.01%)
firebase-componentsapk (aggressive)10945.0010964.00+19.00 (+0.17%)
firebase-abtapk (aggressive)85717.0085706.00-11.00 (-0.01%)
firebase-configapk (aggressive)395817.00395835.00+18.00 (+0.00%)
firebase-datatransportapk (aggressive)116364.00116351.00-13.00 (-0.01%)
firebase-inappmessaging-displayapk (aggressive)1813854.001813858.00+4.00 (+0.00%)
firebase-functionsapk (aggressive)393455.00393476.00+21.00 (+0.01%)
firebase-database-collectionapk (aggressive)313605.00313630.00+25.00 (+0.01%)
firebase-firestoreapk (aggressive)443174.00443178.00+4.00 (+0.00%)
baseapk (aggressive)10661.0010669.00+8.00 (+0.08%)
Metric Unit: byte

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 37721c0 into master Apr 2, 2020
@firebase firebase locked and limited conversation to collaborators May 3, 2020
@kaibolay kaibolay deleted the mrschmidt/incrementpublic branch September 14, 2022 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants