Optimize output stream encoding. #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a BufferedWriter which drastically speeds up json encoding, as the encoder makes a lot of one-character writes so not buffering them leads to significant uft-8 encoding overhead. * Encode directly into the connection as opposed to an intermediate byte array. * Switch to try-with-resources for better resource safety
Binary Size ReportAffected SDKs
Test Logs |
|
/retest |
mrwillis21
approved these changes
Apr 3, 2020
|
/retest |
vkryachko
force-pushed
the
vk.transport_buffer
branch
from
e0a7226 to
cb5590b
Compare
vkryachko
force-pushed
the
vk.transport_buffer
branch
from
5c43bd3 to
2518e80
Compare
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encoder makes a lot of one-character writes so not buffering them
leads to significant uft-8 encoding overhead.
byte array.