Skip to content

Migrate transport backend to auto @Encodable codegen. #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Migrate transport backend to auto @Encodable codegen. #1427

merged 1 commit into from
Apr 9, 2020

Conversation

vkryachko
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Override cla label Apr 6, 2020
@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

SDKTypeBase (ef455a6)Head (029b0b5)Diff
transport-backend-cct0.780.79+0.00 (+0.20%)
AutoValue_LogEvent.java0.600.60-0.00 (-0.43%)
AutoValue_AndroidClientInfo.java0.550.54-0.01 (-1.91%)
AutoBatchedLogRequestEncoder.java?1.00? (?)
AutoValue_LogRequest.java0.580.59+0.01 (+1.80%)
Metric Unit: percentage

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage. Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 6, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (ef455a6)Head (029b0b5)Diff
firebase-inappmessagingapk (release)3552236.003552244.00+8.00 (+0.00%)
apk (aggressive)852409.00852545.00+136.00 (+0.02%)
firebase-segmentationapk (aggressive)801531.00801530.00-1.00 (-0.00%)
firebase-storageapk (aggressive)325641.00325639.00-2.00 (-0.00%)
firebase-commonapk (aggressive)82954.0082943.00-11.00 (-0.01%)
firebase-crashlytics-ndkapk (release)1937531.001937482.00-49.00 (-0.00%)
apk (aggressive)1170760.001170954.00+194.00 (+0.02%)
transport:transport-backend-cctaar38357.0038946.00+589.00 (+1.54%)
firebase-crashlyticsapk (release)1354614.001354373.00-241.00 (-0.02%)
apk (aggressive)583863.00583941.00+78.00 (+0.01%)
firebase-installationsapk (aggressive)84598.0084601.00+3.00 (+0.00%)
firebase-dynamic-linksapk (aggressive)327465.00327463.00-2.00 (-0.00%)
firebase-installations-interopapk (aggressive)61714.0061720.00+6.00 (+0.01%)
firebase-componentsapk (aggressive)10949.0010964.00+15.00 (+0.14%)
firebase-abtapk (aggressive)85717.0085723.00+6.00 (+0.01%)
firebase-configapk (aggressive)395832.00395836.00+4.00 (+0.00%)
firebase-datatransportapk (release)711405.00711422.00+17.00 (+0.00%)
apk (aggressive)116378.00116495.00+117.00 (+0.10%)
firebase-inappmessaging-displayapk (release)4818362.004818313.00-49.00 (-0.00%)
apk (aggressive)1814120.001814404.00+284.00 (+0.02%)
firebase-functionsapk (aggressive)393472.00393459.00-13.00 (-0.00%)
firebase-database-collectionapk (aggressive)313619.00313609.00-10.00 (-0.00%)
firebase-firestoreapk (aggressive)443191.00443195.00+4.00 (+0.00%)
baseapk (aggressive)10682.0010680.00-2.00 (-0.02%)
Metric Unit: byte

Test Logs

@vkryachko vkryachko requested a review from ashwinraghav April 7, 2020 03:07
@VinayGuthal VinayGuthal self-requested a review April 9, 2020 15:41
@vkryachko vkryachko merged commit 035329d into master Apr 9, 2020
@vkryachko vkryachko deleted the vk.transport_auto_encodable branch April 21, 2020 15:28
@firebase firebase locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

Assignees
No one assigned
Labels
cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @google-oss-bot @VinayGuthal @googlebot