Skip to content

Add GMPID header to the RTDB SDK #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Override cla label Jun 1, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 1, 2020

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (3ffa95f) Head (28c4d960) Diff
    apk (aggressive) 82.5 kB 82.5 kB -5 B (-0.0%)
    apk (debug) 770 kB 770 kB -59 B (-0.0%)
  • firebase-components

    Type Base (3ffa95f) Head (28c4d960) Diff
    apk (aggressive) 11.0 kB 10.9 kB -15 B (-0.1%)
    apk (debug) 35.9 kB 35.8 kB -34 B (-0.1%)
  • firebase-database

    Type Base (3ffa95f) Head (28c4d960) Diff
    aar 482 kB 482 kB +165 B (+0.0%)
    apk (aggressive) 326 kB 326 kB -4 B (-0.0%)
    apk (debug) 1.29 MB 1.29 MB -151 B (-0.0%)
    apk (release) 1.09 MB 1.09 MB +95 B (+0.0%)
  • firebase-database-collection

    Type Base (3ffa95f) Head (28c4d960) Diff
    apk (aggressive) 314 kB 314 kB +2 B (+0.0%)
    apk (debug) 1.07 MB 1.07 MB +23 B (+0.0%)

Test Logs

Notes

Head commit (28c4d960) is created by Prow via merging commits: 3ffa95f 7e85e89.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.13% (3ffa95f) to 51.22% (28c4d960) by +0.09%.

    Filename Base (3ffa95f) Head (28c4d960) Diff
    ChildChangeAccumulator.java 83.87% 96.77% +12.90%
    ConnectionContext.java 87.50% 88.89% +1.39%
    Context.java 75.70% 75.93% +0.22%
    DoubleNode.java 88.89% 100.00% +11.11%
    WebsocketConnection.java 32.00% 32.39% +0.39%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (28c4d960) is created by Prow via merging commits: 3ffa95f 7e85e89.

@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 7e85e89 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@schmidt-sebastian schmidt-sebastian merged commit 60fff09 into master Jun 5, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/gmpid branch June 5, 2020 03:42
@firebase firebase locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants